Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Unified Diff: runtime/vm/assembler_mips.h

Issue 12340050: Add DISALLOW_COPY_AND_ASSIGN to subclasses of ValueObject and make ValueObject copyable. Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_ia32.h ('k') | runtime/vm/assembler_x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_mips.h
===================================================================
--- runtime/vm/assembler_mips.h (revision 18957)
+++ runtime/vm/assembler_mips.h (working copy)
@@ -15,16 +15,6 @@
namespace dart {
class Operand : public ValueObject {
- public:
- Operand(const Operand& other) : ValueObject() {
- UNIMPLEMENTED();
- }
-
- Operand& operator=(const Operand& other) {
- UNIMPLEMENTED();
- return *this;
- }
-
protected:
Operand() { } // Needed by subclass Address.
};
@@ -35,13 +25,6 @@
Address(Register base, int32_t disp) {
UNIMPLEMENTED();
}
-
- Address(const Address& other) : Operand(other) { }
-
- Address& operator=(const Address& other) {
- Operand::operator=(other);
- return *this;
- }
};
@@ -49,13 +32,6 @@
public:
FieldAddress(Register base, int32_t disp)
: Address(base, disp - kHeapObjectTag) { }
-
- FieldAddress(const FieldAddress& other) : Address(other) { }
-
- FieldAddress& operator=(const FieldAddress& other) {
- Address::operator=(other);
- return *this;
- }
};
@@ -198,7 +174,6 @@
GrowableArray<CodeComment*> comments_;
- DISALLOW_ALLOCATION();
DISALLOW_COPY_AND_ASSIGN(Assembler);
};
« no previous file with comments | « runtime/vm/assembler_ia32.h ('k') | runtime/vm/assembler_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698