Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 12340046: Merge 143363 (Closed)

Created:
7 years, 10 months ago by Noel Gordon
Modified:
7 years, 10 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 143363 > Update FeatureObserver on top level navigation in addition to page destruction. > https://bugs.webkit.org/show_bug.cgi?id=109874 > > Patch by Kassy Coan <kassycoan@chromium.org>; on 2013-02-19 > Reviewed by Adam Barth. > > No new tests. Only effect is to histogram more frequently. > > * loader/FrameLoader.cpp: > (WebCore::FrameLoader::dispatchDidCommitLoad): > * page/FeatureObserver.cpp: > (WebCore::FeatureObserver::~FeatureObserver): > (WebCore): > (WebCore::FeatureObserver::updateMeasurements): > (WebCore::FeatureObserver::didCommitLoad): > * page/FeatureObserver.h: > (FeatureObserver): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M Source/WebCore/loader/FrameLoader.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebCore/page/FeatureObserver.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/WebCore/page/FeatureObserver.cpp View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Noel Gordon
7 years, 10 months ago (2013-02-25 03:35:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698