Remove base/mac/scoped_nsexception_enabler.h.

Remove base/mac/scoped_nsexception_enabler.h.

Exception fatalisation is now handled via base::mac::CallWithEHFrame, so
this file is unnecessary.

The base::mac::ScopedNSExceptionEnabler is removed, since instantiating an
NSException is no longer fatal (only an uncaught one is).
base::mac::RunBlockIgnoringExceptions has been removed where possible or converted
to a @try/@catch to swallow any exceptions.

BUG=503128
R=shess@chromium.org

Committed: https://crrev.com/787e2b2d0110448a5added6c9aae8fc7f9134144
Cr-Commit-Position: refs/heads/master@{#339884}

[Scott Hess - ex-Googler, 2015-07-21 16:33:13]

LGTM!

[Robert Sesek, 2015-07-21 18:55:01]

rsesek@chromium.org changed reviewers:
+ dalecurtis@chromium.org, estade@chromium.org, thakis@chromium.org,
vitalybuka@chromium.org

[Robert Sesek, 2015-07-21 18:55:02]

thakis: //base, //chrome, //ui OWNERS
estade: //components/autofill OWNERS
dalecurtis: //media OWNERS
vitalybuka: //printing OWNERS

[Nico, 2015-07-21 18:59:09]

lgtm

[DaleCurtis, 2015-07-21 19:04:57]

media/ lgtm

[Evan Stade, 2015-07-21 19:53:35]

estade@chromium.org changed reviewers:
+ isherman@chromium.org

[Evan Stade, 2015-07-21 19:53:35]

-estade, +isherman for autofill (because it's mac address book code)

[Evan Stade, 2015-07-21 19:53:51]

ah, since Ilya is OOO, rs lgtm

[Vitaly Buka (NO REVIEWS), 2015-07-22 02:07:49]

The CQ bit was checked by vitalybuka@chromium.org

[Vitaly Buka (NO REVIEWS), 2015-07-22 02:07:50]

lgtm

[Vitaly Buka (NO REVIEWS), 2015-07-22 02:08:07]

The CQ bit was unchecked by vitalybuka@chromium.org

[Robert Sesek, 2015-07-22 03:32:37]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2015-07-22 03:32:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1233983004/1

[commit-bot: I haz the power, 2015-07-22 03:34:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-22 03:34:38]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Robert Sesek, 2015-07-22 15:00:18]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2015-07-22 15:00:19]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org,
thakis@chromium.org, dalecurtis@chromium.org, shess@chromium.org,
vitalybuka@chromium.org
Link to the patchset: https://codereview.chromium.org/1233983004/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2015-07-22 15:00:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1233983004/20001

[commit-bot: I haz the power, 2015-07-22 16:06:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-22 16:07:17]

Patchset 2 (id:??) landed as
https://crrev.com/787e2b2d0110448a5added6c9aae8fc7f9134144
Cr-Commit-Position: refs/heads/master@{#339884}

[Avi (use Gerrit), 2015-07-28 13:23:16]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2015-07-28 13:23:17]

https://codereview.chromium.org/1233983004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/personal_data_manager_mac.mm (right):

https://codereview.chromium.org/1233983004/diff/20001/components/autofill/cor...
components/autofill/core/browser/personal_data_manager_mac.mm:126: // caught by
AppKit and it should be swallowed. http://crbug.com/129022
I believe that exceptions actually do leak from here for malformed address
books; see http://www.openradar.me/12276058 which I filed.

[Scott Hess - ex-Googler, 2015-07-28 19:29:14]

https://codereview.chromium.org/1233983004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/personal_data_manager_mac.mm (right):

https://codereview.chromium.org/1233983004/diff/20001/components/autofill/cor...
components/autofill/core/browser/personal_data_manager_mac.mm:126: // caught by
AppKit and it should be swallowed. http://crbug.com/129022
On 2015/07/28 13:23:17, Avi wrote:
> I believe that exceptions actually do leak from here for malformed address
> books; see http://www.openradar.me/12276058 which I filed.

Looking at the crash server, I think it will be interesting to see if we still
see a bunch of crashes in there due to exceptions, or if the just plain old
crashes in the AB* code overwhelms.