Remove base/mac/scoped_nsexception_enabler.h.

components/autofill/core/browser/personal_data_manager_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <math.h>
 
 #import <AddressBook/AddressBook.h>
 
 #include "base/format_macros.h"
 #include "base/guid.h"
 #include "base/logging.h"
-#import "base/mac/scoped_nsexception_enabler.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/time/time.h"
 #include "components/autofill/core/browser/autofill_country.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_type.h"
@@ skipping 90 matching lines @@
   // weeks, and there are no major problems, rip out all the code. Expected
   // removal date: 07/15/2015. http://crbug.com/488146.
   return nil;
 
   bool first_access = !HasQueriedMacAddressBook(pref_service);
 
   base::Time start_time = base::Time::Now();
   // +[ABAddressBook sharedAddressBook] throws an exception internally in
   // circumstances that aren't clear. The exceptions are only observed in crash
   // reports, so it is unknown whether they would be caught by AppKit and nil
-  // returned, or if they would take down the app. In either case, avoid
-  // crashing. http://crbug.com/129022
-  ABAddressBook* addressBook = base::mac::RunBlockIgnoringExceptions(
-      ^{ return [ABAddressBook sharedAddressBook]; });
+  // returned, or if they would take down the app.
+  // TODO(rsesek): If a crash is observed here, then the exception is not being
+  // caught by AppKit and it should be swallowed. http://crbug.com/129022

[Avi (use Gerrit), 2015/07/28 13:23:17]

I believe that exceptions actually do leak from here for malformed address
books; see http://www.openradar.me/12276058 which I filed.

[Scott Hess - ex-Googler, 2015/07/28 19:29:14]

Looking at the crash server, I think it will be interesting to see if we still
see a bunch of crashes in there due to exceptions, or if the just plain old
crashes in the AB* code overwhelms.

+  ABAddressBook* addressBook = [ABAddressBook sharedAddressBook];
   UMA_HISTOGRAM_BOOLEAN("Autofill.AddressBookAvailable", addressBook != nil);
 
   if (!g_accessed_address_book) {
     // The amount of time that the access takes gives a good indication as to
     // whether the user was shown a prompt.
     UMA_HISTOGRAM_TIMES("Autofill.MacAddressBook.AccessTime",
                         base::Time::Now() - start_time);
   }
 
   if (first_access) {
@@ skipping 356 matching lines @@
 
 int PersonalDataManager::AccessAddressBookPromptCount() {
   return pref_service_->GetInteger(prefs::kAutofillMacAddressBookShowedCount);
 }
 
 void PersonalDataManager::BinaryChanging() {
   g_binary_changed = true;
 }
 
 }  // namespace autofill