Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1233933002: Get rid of GrMurmur3Hash (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nothing #

Total comments: 1

Patch Set 3 : tidy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -89 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D src/gpu/GrMurmur3HashKey.h View 1 chunk +0 lines, -73 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.h View 1 2 3 chunks +11 lines, -9 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
joshualitt
one more mini cleanup, ptal.
5 years, 5 months ago (2015-07-13 19:21:18 UTC) #2
mtklein
https://codereview.chromium.org/1233933002/diff/20001/src/gpu/effects/GrTextureStripAtlas.h File src/gpu/effects/GrTextureStripAtlas.h (right): https://codereview.chromium.org/1233933002/diff/20001/src/gpu/effects/GrTextureStripAtlas.h#newcode29 src/gpu/effects/GrTextureStripAtlas.h:29: uint16_t fWidth, fHeight, fRowHeight; It might be a good ...
5 years, 5 months ago (2015-07-13 19:26:11 UTC) #4
robertphillips
lgtm modulo Mike's comment
5 years, 5 months ago (2015-07-13 19:34:28 UTC) #5
mtklein
On 2015/07/13 19:34:28, robertphillips wrote: > lgtm modulo Mike's comment (This also LGTM. My comment ...
5 years, 5 months ago (2015-07-13 19:35:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233933002/40001
5 years, 5 months ago (2015-07-13 19:42:10 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 19:49:16 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/690fc75b29de659b1844d4a36d3f101e98ad1106

Powered by Google App Engine
This is Rietveld 408576698