Make File-Picker modal on Linux

chrome/browser/ui/browser.h

Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index f44f3f02a98f3cc77ca89d2ea8f9813a00f9e5b0..9ebb407b3cc27ab0216bf8d758a781cc774916bc 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -400,6 +400,8 @@ class Browser : public TabStripModelObserver,
 
   // Show various bits of UI
   void OpenFile();
+  // Close the file dialog for BrowserViewFocusTest.BrowserDialogModalTest.
+  void CloseFileDialog();

[msw, 2015/09/23 17:12:21]

Adding public API to Browser (especially test-specific API, which should be
named "CloseFileDialogForTesting") is not really desirable.

I suggest making OpenFile return a scoped_refptr<ui::SelectFileDialog> reference
to the dialog, so that callers can interact with the dialog as needed.

Otherwise, *maybe* adding something like: scoped_refptr<ui::SelectFileDialog>
ui::SelectFileDialog::GetDialogForListener(ui::SelectFileDialog::Listener*
listener) (which checks a cached map of listeners to their open dialogs) might
be preferable to adding this new Browser::CloseFileDialogForTesting() function.

I'd ask that others on this CL weigh in.

 
   void UpdateDownloadShelfVisibility(bool visible);