Make File-Picker modal on Linux

chrome/browser/ui/browser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_H_
 #define CHROME_BROWSER_UI_BROWSER_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 382 matching lines @@
   // in |SupportsWindowFeature| for details on this.
   bool CanSupportWindowFeature(WindowFeature feature) const;
 
   // TODO(port): port these, and re-merge the two function declaration lists.
   // Page-related commands.
   void ToggleEncodingAutoDetect();
   void OverrideEncoding(int encoding_id);
 
   // Show various bits of UI
   void OpenFile();
+  // Close the file dialog for BrowserViewFocusTest.BrowserDialogModalTest.
+  void CloseFileDialog();

[msw, 2015/09/23 17:12:21]

Adding public API to Browser (especially test-specific API, which should be
named "CloseFileDialogForTesting") is not really desirable.

I suggest making OpenFile return a scoped_refptr<ui::SelectFileDialog> reference
to the dialog, so that callers can interact with the dialog as needed.

Otherwise, *maybe* adding something like: scoped_refptr<ui::SelectFileDialog>
ui::SelectFileDialog::GetDialogForListener(ui::SelectFileDialog::Listener*
listener) (which checks a cached map of listeners to their open dialogs) might
be preferable to adding this new Browser::CloseFileDialogForTesting() function.

I'd ask that others on this CL weigh in.

 
   void UpdateDownloadShelfVisibility(bool visible);
 
   /////////////////////////////////////////////////////////////////////////////
 
   // Called by chrome::Navigate() when a navigation has occurred in a tab in
   // this Browser. Updates the UI for the start of this navigation.
   void UpdateUIForNavigationInTab(content::WebContents* contents,
                                   ui::PageTransition transition,
                                   bool user_initiated);
@@ skipping 570 matching lines @@
   // The following factory is used for chrome update coalescing.
   base::WeakPtrFactory<Browser> chrome_updater_factory_;
 
   // The following factory is used to close the frame at a later time.
   base::WeakPtrFactory<Browser> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Browser);
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_H_