Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7820)

Unified Diff: build/secondary/third_party/nss/BUILD.gn

Issue 1233913002: Refactor incompatible pointer type to a config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added mipsel clause back Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | gpu/gles2_conform_support/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/third_party/nss/BUILD.gn
diff --git a/build/secondary/third_party/nss/BUILD.gn b/build/secondary/third_party/nss/BUILD.gn
index 25d449e14dc171b3635d59ff3d54e022fd3cf196..73b9711a3caa5003a3de62df019e18561cd724e7 100644
--- a/build/secondary/third_party/nss/BUILD.gn
+++ b/build/secondary/third_party/nss/BUILD.gn
@@ -220,6 +220,9 @@ if (is_linux) {
configs += [
"//build/config/compiler:no_chromium_code",
"//build/config/compiler:no_size_t_to_int_warning",
+
+ # nspr passes "const char*" through "void*".
+ "//build/compiler:no_incompatible_pointer_warnings",
]
cflags = []
@@ -326,9 +329,6 @@ if (is_linux) {
# prlink.c on mac.
"-Wno-deprecated-declarations",
- # nspr passes "const char*" through "void*".
- "-Wno-incompatible-pointer-types",
-
# nspr passes "int*" through "unsigned int*".
"-Wno-pointer-sign",
]
@@ -885,6 +885,9 @@ if (is_linux) {
configs += [
"//build/config/compiler:no_chromium_code",
"//build/config/compiler:no_size_t_to_int_warning",
+
+ # nss passes "const char*" through "void*".
+ "//build/compiler:no_incompatible_pointer_warnings",
]
public_configs = [ ":nss_static_config" ]
@@ -1182,9 +1185,6 @@ if (is_linux) {
# nss doesn"t explicitly cast between different enum types.
"-Wno-conversion",
- # nss passes "const char*" through "void*".
- "-Wno-incompatible-pointer-types",
-
# nss prefers `a && b || c` over `(a && b) || c`.
"-Wno-logical-op-parentheses",
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | gpu/gles2_conform_support/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698