Refactor incompatible pointer type to a config

build/secondary/third_party/nss/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/linux/pkg_config.gni")
 
 if (is_linux) {
   # This is a dependency on NSS with no libssl. On Linux we use a built-in SSL
   # library but the system NSS libraries. Non-Linux platforms using NSS use the
   # hermetic one in //third_party/nss.
@@ skipping 202 matching lines @@
     configs -= [ "//build/config/compiler:chromium_code" ]
     if (is_win) {
       configs -= [
         "//build/config/win:unicode",  # Requires 8-bit mode.
         "//build/config/win:lean_and_mean",  # Won"t compile with lean and mean.
       ]
     }
     configs += [
       "//build/config/compiler:no_chromium_code",
       "//build/config/compiler:no_size_t_to_int_warning",
+
+      # nspr passes "const char*" through "void*".
+      "//build/compiler:no_incompatible_pointer_warnings",
     ]
 
     cflags = []
     defines = [
       "_NSPR_BUILD_",
       "FORCE_PR_LOG",
     ]
 
     include_dirs = [ "nspr/pr/include/private" ]
 
@@ skipping 86 matching lines @@
         "CoreServices.framework",
       ]
     }
 
     if (is_clang) {
       cflags += [
         # nspr uses a bunch of deprecated functions (NSLinkModule etc) in
         # prlink.c on mac.
         "-Wno-deprecated-declarations",
 
-        # nspr passes "const char*" through "void*".
-        "-Wno-incompatible-pointer-types",
-
         # nspr passes "int*" through "unsigned int*".
         "-Wno-pointer-sign",
       ]
 
       # nspr uses assert(!"foo") instead of assert(false && "foo").
       configs -= [ "//build/config/clang:extra_warnings" ]
     }
   }
 
   component("nss") {
@@ skipping 536 matching lines @@
       "nss/lib/pk11wrap/debug_module.c",
     ]
 
     configs -= [ "//build/config/compiler:chromium_code" ]
     if (is_win) {
       configs -= [ "//build/config/win:unicode" ]  # Requires 8-bit mode.
     }
     configs += [
       "//build/config/compiler:no_chromium_code",
       "//build/config/compiler:no_size_t_to_int_warning",
+
+      # nss passes "const char*" through "void*".
+      "//build/compiler:no_incompatible_pointer_warnings",
     ]
     public_configs = [ ":nss_static_config" ]
 
     cflags = []
 
     # Only need the defines and includes not in nss_static_config.
     defines = [
       "MP_API_COMPATIBLE",
       "NSS_DISABLE_DBM",
       "RIJNDAEL_INCLUDE_TABLES",
@@ skipping 277 matching lines @@
         # mpi_x86_asm.c contains MSVC inline assembly code.
         "nss/lib/freebl/mpi/mpi_x86_asm.c",
       ]
     }
 
     if (is_clang) {
       cflags += [
         # nss doesn"t explicitly cast between different enum types.
         "-Wno-conversion",
 
-        # nss passes "const char*" through "void*".
-        "-Wno-incompatible-pointer-types",
-
         # nss prefers `a && b || c` over `(a && b) || c`.
         "-Wno-logical-op-parentheses",
 
         # nss doesn"t use exhaustive switches on enums
         "-Wno-switch",
 
         # nss has some `unsigned < 0` checks.
         "-Wno-tautological-compare",
       ]
     }
 
     public_deps = [
       ":nspr",
     ]
     deps = [
       ":nspr",
       "//third_party/sqlite",
     ]
 
     if (is_win && current_cpu == "x86") {
       deps += [ ":nss_static_avx" ]
     }
   }
 }  # Windows/Mac/iOS.