Enable SDCH support over HTTPS.

net/base/sdch_manager.h

Index: net/base/sdch_manager.h
diff --git a/net/base/sdch_manager.h b/net/base/sdch_manager.h
index 4f45966dd5bc254f1abce816e675c00a79060233..a4cd09824a7da8cac24890b8eb3642288da1427a 100644
--- a/net/base/sdch_manager.h
+++ b/net/base/sdch_manager.h
@@ -251,6 +251,11 @@ class NET_EXPORT SdchManager : public NON_EXPORTED_BASE(base::NonThreadSafe) {
 
   static bool sdch_enabled() { return g_sdch_enabled_; }
 
+  // Enables or disables SDCH compression over secure connection.
+  static void EnableSdchOverSecureSupport(bool enabled);

[jar (doing other things), 2014/01/03 18:35:13]

nit: This is already in the SdchManager class... so a better name might be:

EnableSecureSchemeSupport

[mef, 2014/01/03 20:26:55]

Done.

+
+  static bool sdch_over_secure_enabled() { return g_sdch_over_secure_enabled_; }

[jar (doing other things), 2014/01/03 18:35:13]

nit: secure_scheme_supported

make this a const method.

[mef, 2014/01/03 20:26:55]

Done.
It's static, so it can't be const.

+
   // Briefly prevent further advertising of SDCH on this domain (if SDCH is
   // enabled). After enough calls to IsInSupportedDomain() the blacklisting
   // will be removed.  Additional blacklists take exponentially more calls
@@ -344,6 +349,9 @@ class NET_EXPORT SdchManager : public NON_EXPORTED_BASE(base::NonThreadSafe) {
   // Support SDCH compression, by advertising in headers.
   static bool g_sdch_enabled_;
 
+  // Support SDCH compression over secure connection, by advertising in headers.

[jar (doing other things), 2014/01/03 18:35:13]

nit: Better might be g_secure_scheme_support_

better comment:

Support SDCH compression for HTTPS requests and responses. When supported, HTTPS
applicable dictionaries MUST have been acquired securely via HTTPS.

[mef, 2014/01/03 20:26:55]

Done.

+  static bool g_sdch_over_secure_enabled_;
+
   // A simple implementation of a RFC 3548 "URL safe" base64 encoder.
   static void UrlSafeBase64Encode(const std::string& input,
                                   std::string* output);