Enable SDCH support over HTTPS.

net/base/sdch_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Provides global database of differential decompression dictionaries for the
 // SDCH filter (processes sdch enconded content).
 
 // Exactly one instance of SdchManager is built, and all references are made
 // into that collection.
 //
@@ skipping 233 matching lines @@
   static void SdchErrorRecovery(ProblemCodes problem);
 
   // Register a fetcher that this class can use to obtain dictionaries.
   void set_sdch_fetcher(SdchFetcher* fetcher);
 
   // Enables or disables SDCH compression.
   static void EnableSdchSupport(bool enabled);
 
   static bool sdch_enabled() { return g_sdch_enabled_; }
 
+  // Enables or disables SDCH compression over secure connection.
+  static void EnableSdchOverSecureSupport(bool enabled);

[jar (doing other things), 2014/01/03 18:35:13]

nit: This is already in the SdchManager class... so a better name might be:

EnableSecureSchemeSupport

[mef, 2014/01/03 20:26:55]

Done.

+
+  static bool sdch_over_secure_enabled() { return g_sdch_over_secure_enabled_; }

[jar (doing other things), 2014/01/03 18:35:13]

nit: secure_scheme_supported

make this a const method.

[mef, 2014/01/03 20:26:55]

Done.
It's static, so it can't be const.

+
   // Briefly prevent further advertising of SDCH on this domain (if SDCH is
   // enabled). After enough calls to IsInSupportedDomain() the blacklisting
   // will be removed.  Additional blacklists take exponentially more calls
   // to IsInSupportedDomain() before the blacklisting is undone.
   // Used when filter errors are found from a given domain, but it is plausible
   // that the cause is temporary (such as application startup, where cached
   // entries are used, but a dictionary is not yet loaded).
   static void BlacklistDomain(const GURL& url);
 
   // Used when SEVERE filter errors are found from a given domain, to prevent
@@ skipping 73 matching lines @@
 
   // A map of dictionaries info indexed by the hash that the server provides.
   typedef std::map<std::string, Dictionary*> DictionaryMap;
 
   // The one global instance of that holds all the data.
   static SdchManager* global_;
 
   // Support SDCH compression, by advertising in headers.
   static bool g_sdch_enabled_;
 
+  // Support SDCH compression over secure connection, by advertising in headers.

[jar (doing other things), 2014/01/03 18:35:13]

nit: Better might be g_secure_scheme_support_

better comment:

Support SDCH compression for HTTPS requests and responses. When supported, HTTPS
applicable dictionaries MUST have been acquired securely via HTTPS.

[mef, 2014/01/03 20:26:55]

Done.

+  static bool g_sdch_over_secure_enabled_;
+
   // A simple implementation of a RFC 3548 "URL safe" base64 encoder.
   static void UrlSafeBase64Encode(const std::string& input,
                                   std::string* output);
   DictionaryMap dictionaries_;
 
   // An instance that can fetch a dictionary given a URL.
   scoped_ptr<SdchFetcher> fetcher_;
 
   // List domains where decode failures have required disabling sdch, along with
   // count of how many additonal uses should be blacklisted.
   DomainCounter blacklisted_domains_;
 
   // Support exponential backoff in number of domain accesses before
   // blacklisting expires.
   DomainCounter exponential_blacklist_count;
 
   // List of hostnames for which a latency experiment is allowed (because a
   // round trip test has recently passed).
   ExperimentSet allow_latency_experiment_;
 
   DISALLOW_COPY_AND_ASSIGN(SdchManager);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_SDCH_MANAGER_H_