Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 1233793002: Remove unused ExtraData support on exported mediastream objects. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unused ExtraData support on exported mediastream objects. The Blink exported interfaces RTCSessionDescriptionRequest, RTCVoidRequest, and MediaStreamTrackSourcesRequest provide a facility to the embedder of allowing 'ExtraData' to be associated and attached to object instances. The embedder does not make use of this functionality for these mediastream objects, so retire the unused ExtraData support. This simplifies the implementation of these exported objects, in particular as regards to when they must be finalized as Blink objects. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198741

Patch Set 1 #

Patch Set 2 : Extend to RTCVoidRequest + MediaStreamTrackSourcesRequest #

Patch Set 3 : include file tidying #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -164 lines) Patch
M Source/platform/exported/WebMediaStreamTrackSourcesRequest.cpp View 1 2 chunks +0 lines, -28 lines 0 comments Download
M Source/platform/exported/WebRTCSessionDescriptionRequest.cpp View 2 chunks +0 lines, -28 lines 0 comments Download
M Source/platform/exported/WebRTCVoidRequest.cpp View 1 2 chunks +0 lines, -28 lines 0 comments Download
M Source/platform/mediastream/MediaStreamTrackSourcesRequest.h View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M Source/platform/mediastream/RTCSessionDescriptionRequest.h View 1 2 1 chunk +1 line, -15 lines 0 comments Download
M Source/platform/mediastream/RTCVoidRequest.h View 1 1 chunk +1 line, -15 lines 0 comments Download
M public/platform/WebMediaStreamTrackSourcesRequest.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M public/platform/WebRTCSessionDescriptionRequest.h View 2 chunks +0 lines, -12 lines 0 comments Download
M public/platform/WebRTCVoidRequest.h View 1 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
haraken
LGTM
5 years, 5 months ago (2015-07-12 10:09:45 UTC) #2
sof
tkent@: agree that just retiring this extra from a public/ header is preferable? (this came ...
5 years, 5 months ago (2015-07-12 13:46:31 UTC) #4
sof
Let's extend this to also cover MediaStreamTrackSourcesRequest and RTCVoidRequest, where this ExtraData functionality is unused ...
5 years, 5 months ago (2015-07-12 14:18:52 UTC) #5
haraken
Still LGTM but I want to have tommi confirm the change.
5 years, 5 months ago (2015-07-12 16:12:53 UTC) #7
sof
On 2015/07/12 16:12:53, haraken wrote: > Still LGTM but I want to have tommi confirm ...
5 years, 5 months ago (2015-07-12 17:55:12 UTC) #8
tommi (sloooow) - chröme
lgtm
5 years, 5 months ago (2015-07-12 18:32:39 UTC) #9
tkent
lgtm
5 years, 5 months ago (2015-07-12 23:30:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233793002/40001
5 years, 5 months ago (2015-07-12 23:30:22 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-12 23:33:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198741

Powered by Google App Engine
This is Rietveld 408576698