Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1227533004: Oilpan: Eagerly finalize RTCSessionDescriptionRequest (Closed)

Created:
5 years, 5 months ago by haraken
Modified:
5 years, 5 months ago
Reviewers:
keishi, oilpan-reviews, sof
CC:
blink-reviews, tommyw+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Eagerly finalize RTCSessionDescriptionRequest RTCSessionDescriptionRequest::m_extraData must be eagerly finalized. Otherwise, it can happen that the RTCSessionDescriptionRequest is accessed after the RTCSessionDescriptionRequest gets destructed in an early stage of the lazy sweeping. BUG=507307 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/platform/mediastream/RTCSessionDescriptionRequest.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL
5 years, 5 months ago (2015-07-07 00:31:22 UTC) #2
keishi
lgtm
5 years, 5 months ago (2015-07-07 02:47:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227533004/1
5 years, 5 months ago (2015-07-07 03:19:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198357
5 years, 5 months ago (2015-07-07 03:22:35 UTC) #6
sof
5 years, 5 months ago (2015-07-12 07:10:39 UTC) #8
Message was sent while issue was closed.
This ExtraData doesn't appear used by Chrome/ium (nor its unit tests); let's
just try to remove it altogether? https://codereview.chromium.org/1233793002/
does so.

Powered by Google App Engine
This is Rietveld 408576698