Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1233673003: Fix bugs found by Dart analyzer (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel, eseidel1, Hixie
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix bugs found by Dart analyzer Now that we have the analyzer working locally, it shows us lots of bugs. This CL fixes the bugs. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/19084533b10d01d20379c19c797667cab9261538

Patch Set 1 #

Patch Set 2 : typo #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
M sky/sdk/example/demo_launcher/lib/main.dart View 2 chunks +1 line, -4 lines 0 comments Download
M sky/sdk/example/game/lib/game_demo_world.dart View 3 chunks +1 line, -4 lines 0 comments Download
M sky/sdk/example/game/lib/particle_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/game/lib/sprite_box.dart View 1 chunk +1 line, -3 lines 0 comments Download
M sky/sdk/example/raw/baseline.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/example/raw/hello_world.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/raw/painting.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/raw/painting_node.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sky/sdk/example/raw/shadow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/raw/spinning_arabic.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/raw/spinning_image.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/raw/spinning_square.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/rendering/sector_layout.dart View 2 chunks +3 lines, -1 line 2 comments Download
M sky/sdk/lib/mojo/asset_bundle.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
abarth-chromium
5 years, 5 months ago (2015-07-10 17:19:34 UTC) #1
eseidel
lgtm
5 years, 5 months ago (2015-07-10 17:20:49 UTC) #3
abarth-chromium
Committed patchset #2 (id:20001) manually as 19084533b10d01d20379c19c797667cab9261538 (presubmit successful).
5 years, 5 months ago (2015-07-10 17:21:39 UTC) #4
Hixie
https://codereview.chromium.org/1233673003/diff/20001/sky/sdk/example/rendering/sector_layout.dart File sky/sdk/example/rendering/sector_layout.dart (right): https://codereview.chromium.org/1233673003/diff/20001/sky/sdk/example/rendering/sector_layout.dart#newcode101 sky/sdk/example/rendering/sector_layout.dart:101: Rect get paintBounds => new Rect.fromLTWH(0.0, 0.0, 2.0 * ...
5 years, 5 months ago (2015-07-10 18:01:01 UTC) #6
abarth-chromium
5 years, 5 months ago (2015-07-10 18:09:30 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1233673003/diff/20001/sky/sdk/example/renderi...
File sky/sdk/example/rendering/sector_layout.dart (right):

https://codereview.chromium.org/1233673003/diff/20001/sky/sdk/example/renderi...
sky/sdk/example/rendering/sector_layout.dart:101: Rect get paintBounds => new
Rect.fromLTWH(0.0, 0.0, 2.0 * deltaRadius, 2.0 * deltaRadius);
On 2015/07/10 at 18:01:01, Hixie wrote:
> this seems wrong. the origin is on the middle of the circle. this should
probably be from -radius-deltaRadius to radius+deltaRadius.

Ok.  Currently it's not used by anything because none of the sectors create
their own display list.

Powered by Google App Engine
This is Rietveld 408576698