Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(381)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: sky/sdk/example/game/lib/particle_system.dart
Issue
1233673003
:
Fix bugs found by Dart analyzer (Closed)
Base URL: git@github.com:domokit/mojo.git@master
Patch Set: typo
Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
sky/sdk/example/demo_launcher/lib/main.dart
sky/sdk/example/game/lib/game_demo_world.dart
sky/sdk/example/game/lib/particle_system.dart
sky/sdk/example/game/lib/sprite_box.dart
sky/sdk/example/raw/baseline.dart
sky/sdk/example/raw/hello_world.dart
sky/sdk/example/raw/painting.dart
sky/sdk/example/raw/painting_node.dart
sky/sdk/example/raw/shadow.dart
sky/sdk/example/raw/spinning_arabic.dart
sky/sdk/example/raw/spinning_image.dart
sky/sdk/example/raw/spinning_square.dart
sky/sdk/example/rendering/sector_layout.dart
sky/sdk/lib/mojo/asset_bundle.dart
View unified diff
|
Download patch
« no previous file with comments
|
« sky/sdk/example/game/lib/game_demo_world.dart
('k') |
sky/sdk/example/game/lib/sprite_box.dart »
('j') |
sky/sdk/example/rendering/sector_layout.dart »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 part of sprites;
1 part of sprites;
2
2
3 class _Particle {
3 class _Particle {
4 Vector2 pos;
4 Vector2 pos;
5 Vector2 startPos;
5 Vector2 startPos;
6
6
7 double colorPos;
7 double colorPos;
8 double deltaColorPos;
8 double deltaColorPos;
9
9
10 double size;
10 double size;
(...skipping
298
matching lines...)
Expand 10 before
|
Expand all
|
Expand 10 after
Loading...
309 }
309 }
310
310
311 // TODO: Needs bindings to Skia SkRSXform
311 // TODO: Needs bindings to Skia SkRSXform
312 class RSTransform {
312 class RSTransform {
313 double scos;
313 double scos;
314 double ssin;
314 double ssin;
315 double tx;
315 double tx;
316 double ty;
316 double ty;
317
317
318 RSTransform(this.scos, this.ssin, this.tx, this.ty);
318 RSTransform(this.scos, this.ssin, this.tx, this.ty);
319
}
319
}
OLD
NEW
« no previous file with comments
|
« sky/sdk/example/game/lib/game_demo_world.dart
('k') |
sky/sdk/example/game/lib/sprite_box.dart »
('j') |
sky/sdk/example/rendering/sector_layout.dart »
('J')
Issue 1233673003: Fix bugs found by Dart analyzer (Closed)
Created 5 years, 5 months ago by abarth-chromium
Modified 5 years, 5 months ago
Reviewers: eseidel1, eseidel, Hixie
Base URL: git@github.com:domokit/mojo.git@master
Comments: 2
This is Rietveld
408576698
Chromium Code Reviews
Issue 1233673003:
Fix bugs found by Dart analyzer (Closed)
Base URL: git@github.com:domokit/mojo.git@master