Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1233563005: Take the ScriptOrigin into account for CompileFunctionInContext (Closed)

Created:
5 years, 5 months ago by epertoso
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Take the ScriptOrigin into account for CompileFunctionInContext R=jochen@chromium.org,yangguo@chromium.org LOG=n BUG= Committed: https://crrev.com/f24ebb324a21dede00bc087fbd74b46504c8314b Cr-Commit-Position: refs/heads/master@{#29700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -9 lines) Patch
M src/api.cc View 1 chunk +20 lines, -4 lines 0 comments Download
M src/compiler.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
epertoso
5 years, 5 months ago (2015-07-16 10:49:12 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233563005/1
5 years, 5 months ago (2015-07-16 10:49:33 UTC) #3
jochen (gone - plz use gerrit)
lgtm from my side, but please also wait for Yang
5 years, 5 months ago (2015-07-16 10:56:24 UTC) #4
Yang
On 2015/07/16 10:56:24, jochen wrote: > lgtm from my side, but please also wait for ...
5 years, 5 months ago (2015-07-16 11:14:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-16 11:15:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233563005/1
5 years, 5 months ago (2015-07-16 12:06:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 12:08:05 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 12:08:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f24ebb324a21dede00bc087fbd74b46504c8314b
Cr-Commit-Position: refs/heads/master@{#29700}

Powered by Google App Engine
This is Rietveld 408576698