src/messages.js - Issue 1233563005: Take the ScriptOrigin into account for CompileFunctionInContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.js

Issue 1233563005: Take the ScriptOrigin into account for CompileFunctionInContext (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.js

diff --git a/src/messages.js b/src/messages.js

index d7ca7cd6479bd85bbdecf3647dc941ae4c9460a1..2f3e5edf945dafde755e5fe9eed94660b11815b9 100644

--- a/src/messages.js

+++ b/src/messages.js

@@ -543,7 +543,7 @@ function GetPositionInLine(message) {

var start_position = %MessageGetStartPosition(message);

var location = script.locationFromPosition(start_position, false);

if (location == null) return -1;

- return start_position - location.start;

+ return location.column;

}

« no previous file with comments | « src/compiler.cc ('k') | test/cctest/test-compiler.cc » ('j') | no next file with comments »