Switch from using individual methods for hyphenation to using the WebHyphantor interface

Switch from using individual methods for hyphenation to using the WebHyphantor interface

Also allow the content embedder to override the hyphenator used.

BUG=178693
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185486

[jochen (gone - plz use gerrit), 2013-02-27 14:12:36]

plz review

[jochen (gone - plz use gerrit), 2013-02-27 21:19:35]

the webkit side has landed

[darin (slow to review), 2013-02-27 21:59:46]

https://codereview.chromium.org/12335128/diff/3001/webkit/mocks/mock_webhyphe...
File webkit/mocks/mock_webhyphenator.cc (right):

https://codereview.chromium.org/12335128/diff/3001/webkit/mocks/mock_webhyphe...
webkit/mocks/mock_webhyphenator.cc:47: size_t
MockWebHyphenator::computeLastHyphenLocation(
Is this really a "mock" hyphenator?  It seems like a real hyphenator.  What am I
missing?

Maybe this is a special hyphenator intended only for use by DRT?  We often use
the Test* or Simple* prefixes for those.

[jochen (gone - plz use gerrit), 2013-02-28 07:00:54]

It's used for DRT and content shell. I'll rename it to Test... and move it
to webkit/glue

Does the change otherwise look good?
On Feb 27, 2013 10:59 PM, <darin@chromium.org> wrote:

>
> https://codereview.chromium.**org/12335128/diff/3001/webkit/**
>
mocks/mock_webhyphenator.cc<https://codereview.chromium.org/12335128/diff/3001/webkit/mocks/mock_webhyphenator.cc>
> File webkit/mocks/mock_**webhyphenator.cc (right):
>
> https://codereview.chromium.**org/12335128/diff/3001/webkit/**
>
mocks/mock_webhyphenator.cc#**newcode47<https://codereview.chromium.org/12335128/diff/3001/webkit/mocks/mock_webhyphenator.cc#newcode47>
> webkit/mocks/mock_**webhyphenator.cc:47: size_t
> MockWebHyphenator::**computeLastHyphenLocation(
> Is this really a "mock" hyphenator?  It seems like a real hyphenator.
> What am I missing?
>
> Maybe this is a special hyphenator intended only for use by DRT?  We
> often use the Test* or Simple* prefixes for those.
>
>
https://codereview.chromium.**org/12335128/<https://codereview.chromium.org/1...
>

[jochen (gone - plz use gerrit), 2013-02-28 07:00:58]

It's used for DRT and content shell. I'll rename it to Test... and move it
to webkit/glue

Does the change otherwise look good?
On Feb 27, 2013 10:59 PM, <darin@chromium.org> wrote:

>
> https://codereview.chromium.**org/12335128/diff/3001/webkit/**
>
mocks/mock_webhyphenator.cc<https://codereview.chromium.org/12335128/diff/3001/webkit/mocks/mock_webhyphenator.cc>
> File webkit/mocks/mock_**webhyphenator.cc (right):
>
> https://codereview.chromium.**org/12335128/diff/3001/webkit/**
>
mocks/mock_webhyphenator.cc#**newcode47<https://codereview.chromium.org/12335128/diff/3001/webkit/mocks/mock_webhyphenator.cc#newcode47>
> webkit/mocks/mock_**webhyphenator.cc:47: size_t
> MockWebHyphenator::**computeLastHyphenLocation(
> Is this really a "mock" hyphenator?  It seems like a real hyphenator.
> What am I missing?
>
> Maybe this is a special hyphenator intended only for use by DRT?  We
> often use the Test* or Simple* prefixes for those.
>
>
https://codereview.chromium.**org/12335128/<https://codereview.chromium.org/1...
>

[darin (slow to review), 2013-02-28 07:03:20]

should it really live in webkit/glue/ if it is not intended to be part of a
chrome build?

[darin (slow to review), 2013-02-28 07:24:36]

OK.. please just add a comment in mock_webhyphenator.h explaining how it is a
mock implementation (i.e., that it only supports en-US).

[darin (slow to review), 2013-02-28 07:25:24]

LGTM

[commit-bot: I haz the power, 2013-02-28 18:48:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/12335128/13001

[commit-bot: I haz the power, 2013-02-28 23:26:56]

Retried try job too often on win_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[jochen (gone - plz use gerrit), 2013-03-01 07:48:12]

Committed patchset #3 manually as r185486 (presubmit successful).