Issue 12335105: Merge 184048

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12335105: Merge 184048 (Closed)

Created:
7 years, 10 months ago by Chris Evans

Modified:
7 years, 10 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1364/src/

Visibility:
Public.

More Reviews

Description

Merge 184048 > Fix crash in VideoRendererBase::ThreadMain(). > > The interleaving of VideoRendererBase::Stop() with outstanding asynchronous calls to a VideoDecoder would result in continuing to execute code (e.g., starting up a thread) on a stopped VideoRendererBase. The most common manifestation of the bug was crashing in ThreadMain() as VideoRendererBase was being destroyed. > > The CHECK()s added to ~VideoRendererBase() in r180573 will stay there as they've proven useful. > > BUG=174150 > > > Review URL: https://chromiumcodereview.appspot.com/12324005 TBR=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184729

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -5 lines)			Patch
M	media/filters/video_renderer_base.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	media/filters/video_renderer_base.cc	View	5 chunks	+13 lines, -1 line	0 comments	Download
M	media/filters/video_renderer_base_unittest.cc	View	4 chunks	+40 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r184729.

Expand Messages | Collapse Messages