Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: media/filters/video_renderer_base.cc

Issue 12335105: Merge 184048 (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1364/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/video_renderer_base.h ('k') | media/filters/video_renderer_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/video_renderer_base.cc
===================================================================
--- media/filters/video_renderer_base.cc (revision 184723)
+++ media/filters/video_renderer_base.cc (working copy)
@@ -116,7 +116,12 @@
return;
}
- decoder_->Stop(callback);
+ if (decoder_) {
+ decoder_->Stop(callback);
+ return;
+ }
+
+ callback.Run();
}
void VideoRendererBase::StopDecoder(const base::Closure& callback) {
@@ -178,6 +183,7 @@
error_cb_ = error_cb;
get_time_cb_ = get_time_cb;
get_duration_cb_ = get_duration_cb;
+ state_ = kInitializing;
scoped_ptr<VideoDecoderSelector> decoder_selector(
new VideoDecoderSelector(base::MessageLoopProxy::current(),
@@ -205,6 +211,8 @@
if (state_ == kStopped)
return;
+ DCHECK_EQ(state_, kInitializing);
+
if (!selected_decoder) {
state_ = kUninitialized;
base::ResetAndReturn(&init_cb_).Run(DECODER_ERROR_NOT_SUPPORTED);
@@ -610,6 +618,7 @@
return;
case kUninitialized:
+ case kInitializing:
case kPrerolled:
case kFlushingDecoder:
case kFlushed:
@@ -622,6 +631,9 @@
void VideoRendererBase::OnDecoderResetDone() {
base::AutoLock auto_lock(lock_);
+ if (state_ == kStopped)
+ return;
+
DCHECK_EQ(kFlushingDecoder, state_);
DCHECK(!pending_read_);
« no previous file with comments | « media/filters/video_renderer_base.h ('k') | media/filters/video_renderer_base_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698