Issue 12335069: create package symlinks in new folders dartbug.com/6688

Issue 12335069: create package symlinks in new folders dartbug.com/6688 (Closed)

Created:
7 years, 10 months ago by keertip

Modified:
7 years, 10 months ago

Reviewers:
pquitslund, danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

create package symlinks in new folders dartbug.com/6688 Committed: https://code.google.com/p/dart/source/detail?r=19006

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -0 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/projects/CreateFolderWizard.java	View		4 chunks	+44 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danrubel

lgtm https://codereview.chromium.org/12335069/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/projects/CreateFolderWizard.java File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/projects/CreateFolderWizard.java (right): https://codereview.chromium.org/12335069/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/projects/CreateFolderWizard.java#newcode71 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/projects/CreateFolderWizard.java:71: public static final List<String> pubDirectories = Arrays.asList("web", "example", ...

7 years, 10 months ago (2013-02-25 21:44:17 UTC) #3

keertip

Committed patchset #1 manually as r19006 (presubmit successful).

7 years, 10 months ago (2013-02-25 22:02:05 UTC) #4

keertip

7 years, 10 months ago (2013-02-25 22:03:17 UTC) #5

Message was sent while issue was closed.

There is documentation on pub.dartlang. Have added TODO indicating the need to
keep list  in sync.


On 2013/02/25 21:44:17, danrubel wrote:
> lgtm
> 
>
https://codereview.chromium.org/12335069/diff/1/editor/tools/plugins/com.goog...
> File
>
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/projects/CreateFolderWizard.java
> (right):
> 
>
https://codereview.chromium.org/12335069/diff/1/editor/tools/plugins/com.goog...
>
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/projects/CreateFolderWizard.java:71:
> public static final List<String> pubDirectories = Arrays.asList("web",
> "example", "test", "bin");
> How can we keep this in sync with pub?
> Does pub have a file somewhere listing the whitelisted directories?
> If nothing else, please add a TODO indicating that this is an issue.

Expand Messages | Collapse Messages