Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: Source/core/events/EventTarget.cpp

Issue 1233483002: Add counters for add/removeEventListener() called with one argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No [Conditional] support Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/EventTarget.h ('k') | Source/core/events/EventTarget.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/EventTarget.cpp
diff --git a/Source/core/events/EventTarget.cpp b/Source/core/events/EventTarget.cpp
index b009b1d9fc772dfa35e4d3bff65852357e35db86..e01db4f2b3a07898e0edae0a1a832055c7edc309 100644
--- a/Source/core/events/EventTarget.cpp
+++ b/Source/core/events/EventTarget.cpp
@@ -87,16 +87,8 @@ inline LocalDOMWindow* EventTarget::executingWindow()
return 0;
}
-bool EventTarget::addEventListener()
-{
- UseCounter::count(executionContext(), UseCounter::AddEventListenerNoArguments);
- return false;
-}
-
bool EventTarget::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
{
- // FIXME: listener null check should throw TypeError (and be done in
- // generated bindings), but breaks legacy content. http://crbug.com/249598
if (!listener)
return false;
@@ -111,16 +103,8 @@ bool EventTarget::addEventListener(const AtomicString& eventType, PassRefPtr<Eve
return ensureEventTargetData().eventListenerMap.add(eventType, listener, useCapture);
}
-bool EventTarget::removeEventListener()
-{
- UseCounter::count(executionContext(), UseCounter::RemoveEventListenerNoArguments);
- return false;
-}
-
bool EventTarget::removeEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
{
- // FIXME: listener null check should throw TypeError (and be done in
- // generated bindings), but breaks legacy content. http://crbug.com/249598
if (!listener)
return false;
« no previous file with comments | « Source/core/events/EventTarget.h ('k') | Source/core/events/EventTarget.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698