Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: Source/core/events/EventTarget.idl

Issue 1233483002: Add counters for add/removeEventListener() called with one argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No [Conditional] support Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/EventTarget.cpp ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/EventTarget.idl
diff --git a/Source/core/events/EventTarget.idl b/Source/core/events/EventTarget.idl
index 540cecea55b37811da89c002e1abc83eee5f2356..3a37d1936b3dc974e47dc8b287eeb4d89fd56235 100644
--- a/Source/core/events/EventTarget.idl
+++ b/Source/core/events/EventTarget.idl
@@ -28,8 +28,7 @@
// FIXME: first 2 args should be required, but throwing TypeError breaks
// legacy content. http://crbug.com/353484
// FIXME: type should not be nullable.
- // FIXME: capture should have a default value false.
- [Custom=CallEpilogue] void addEventListener(optional DOMString? type, optional EventListener? listener, optional boolean capture);
- [Custom=CallEpilogue] void removeEventListener(optional DOMString? type, optional EventListener? listener, optional boolean capture);
+ [Custom=(CallPrologue,CallEpilogue)] void addEventListener(optional DOMString? type = null, optional EventListener? listener = null, optional boolean capture = false);
+ [Custom=(CallPrologue,CallEpilogue)] void removeEventListener(optional DOMString? type = null, optional EventListener? listener = null, optional boolean capture = false);
[RaisesException] boolean dispatchEvent(Event event);
};
« no previous file with comments | « Source/core/events/EventTarget.cpp ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698