Refactor progressive renderer class.

Refactor progressive renderer class.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/1ccb793f6bcf14c03cb817d0465584c81e1841f8

[Tom Sepez, 2015-07-16 22:27:56]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-07-16 22:27:57]

Lei, for review.  Another object who's constructor doesn't do all it should ...

[Lei Zhang, 2015-07-17 01:06:35]

lgtm

https://codereview.chromium.org/1233453014/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_render.h (right):

https://codereview.chromium.org/1233453014/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_render.h:156: int	EstimateProgress();
remove tab

https://codereview.chromium.org/1233453014/diff/20001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/1233453014/diff/20001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render.cpp:1076:
m_pRenderStatus.reset(nullptr);
just reset() ?
ditto on line 1133

https://codereview.chromium.org/1233453014/diff/20001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1233453014/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:38: static FX_DWORD foxit_sandbox_policy = 0xFFFFFFFF;
would you mind making this a const?

https://codereview.chromium.org/1233453014/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:63: if(foxit_sandbox_policy&0x01)
return foxit_sandbox_policy & 0x01;

https://codereview.chromium.org/1233453014/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:68: break;
no need for a break

https://codereview.chromium.org/1233453014/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:70: break;
just return FALSE

[Tom Sepez, 2015-07-17 16:58:22]

https://codereview.chromium.org/1233453014/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_render.h (right):

https://codereview.chromium.org/1233453014/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_render.h:156: int	EstimateProgress();
On 2015/07/17 01:06:35, Lei Zhang wrote:
> remove tab

Done.

https://codereview.chromium.org/1233453014/diff/20001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/1233453014/diff/20001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render.cpp:1076:
m_pRenderStatus.reset(nullptr);
On 2015/07/17 01:06:35, Lei Zhang wrote:
> just reset() ?
> ditto on line 1133

Done.

https://codereview.chromium.org/1233453014/diff/20001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1233453014/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:38: static FX_DWORD foxit_sandbox_policy = 0xFFFFFFFF;
On 2015/07/17 01:06:35, Lei Zhang wrote:
> would you mind making this a const?
Turns out it gets updated in a couple of places.

https://codereview.chromium.org/1233453014/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:68: break;
On 2015/07/17 01:06:35, Lei Zhang wrote:
> no need for a break

Done.

https://codereview.chromium.org/1233453014/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:70: break;
On 2015/07/17 01:06:35, Lei Zhang wrote:
> just return FALSE

Done.

https://codereview.chromium.org/1233453014/diff/40001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1233453014/diff/40001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:62: return (foxit_sandbox_policy & 0x01) ? TRUE :
FALSE;
Note:  There are important philosophical points to consider here (no, not
really), but I went with this because:
1.  There isn't any reason to believe that the FX-invented TRUE and FALSE (all
caps) will remain 0 and 1, they might be 17 and 142 for all we know.
2.  0x01 should be a constant so we would write f_s_p & MAGIC, at which point
the right thing would be return !!(f_s_p & MAGIC); in case the bit position
moves.
3.  !! is my favorite but torks the newbs, so use ? per point #1.

[Tom Sepez, 2015-07-17 17:29:30]

Committed patchset #3 (id:40001) manually as
1ccb793f6bcf14c03cb817d0465584c81e1841f8 (presubmit successful).