Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 12334105: Add a unit test for Hunspell spellcheck (Closed)

Created:
7 years, 9 months ago by please use gerrit instead
Modified:
7 years, 9 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, groby+spellwatch_chromium.org, rpetterson, darin-cc_chromium.org, rouslan+spellwatch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add a unit test for Hunspell spellcheck Chrome has been suggesting "Othello" for "hellllo" and "identically" for "accidently" because the Chrome version in Hunspell assumed that dictionaries contain at most one affix per entry. This CL adds a unit test that verifies Hunspell no longer has this erroneous assumption. BUG=170668 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184890

Patch Set 1 #

Total comments: 1

Patch Set 2 : Bump hunspell dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
please use gerrit instead
Groby: PTAL. The fix is in https://codereview.chromium.org/12328121/
7 years, 9 months ago (2013-02-26 23:34:11 UTC) #1
groby-ooo-7-16
LGTM - unless you feel inclined to actually create a new test case file for ...
7 years, 9 months ago (2013-02-27 00:51:29 UTC) #2
please use gerrit instead
On 2013/02/27 00:51:29, groby wrote: > unless you feel inclined to actually create a new ...
7 years, 9 months ago (2013-02-27 01:18:56 UTC) #3
please use gerrit instead
Will send to commit queue together with hunspell dependency update after https://codereview.chromium.org/12328121/ lands.
7 years, 9 months ago (2013-02-27 01:19:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/12334105/7001
7 years, 9 months ago (2013-02-27 02:03:40 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-02-27 05:50:47 UTC) #6
Message was sent while issue was closed.
Change committed as 184890

Powered by Google App Engine
This is Rietveld 408576698