Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1233303003: Migrate and merge logging_utils from swarming_bot into client/utils. (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 4 months ago
Reviewers:
Vadim Sh., fdeng
CC:
chromium-reviews
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate and merge logging_utils from swarming_bot into client/utils. This does change the way logging is output. In particular, this sets UTC everywhere. The goal is to make NoInheritRotatingFileHandler accessible to all tools, most importantly run_isolated. R=vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/b2462bd77b2eb4ef63e52aa35cfee5e561cb186d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changed formatter #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -391 lines) Patch
M appengine/swarming/server/bot_archive.py View 2 chunks +1 line, -1 line 0 comments Download
M appengine/swarming/swarming_bot/__main__.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/swarming_bot/bot_main.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/swarming_bot/bot_main_test.py View 1 chunk +1 line, -1 line 0 comments Download
D appengine/swarming/swarming_bot/logging_utils.py View 1 chunk +0 lines, -168 lines 0 comments Download
D appengine/swarming/swarming_bot/logging_utils_test.py View 1 chunk +0 lines, -53 lines 0 comments Download
M appengine/swarming/swarming_bot/task_runner_test.py View 1 chunk +1 line, -1 line 0 comments Download
M client/auth.py View 3 chunks +5 lines, -3 lines 0 comments Download
M client/isolate.py View 2 chunks +2 lines, -1 line 0 comments Download
M client/isolateserver.py View 3 chunks +4 lines, -3 lines 0 comments Download
M client/run_isolated.py View 2 chunks +2 lines, -1 line 0 comments Download
M client/swarming.py View 9 chunks +11 lines, -9 lines 0 comments Download
M client/tests/isolate_test.py View 3 chunks +6 lines, -1 line 0 comments Download
M client/tests/run_isolated_test.py View 2 chunks +4 lines, -0 lines 0 comments Download
M client/tools/parallel_execution.py View 3 chunks +4 lines, -3 lines 0 comments Download
M client/trace_inputs.py View 4 chunks +4 lines, -3 lines 0 comments Download
A + client/utils/logging_utils.py View 1 7 chunks +105 lines, -11 lines 0 comments Download
A + client/utils/logging_utils_test.py View 2 chunks +5 lines, -6 lines 0 comments Download
M client/utils/tools.py View 2 chunks +0 lines, -124 lines 2 comments Download

Messages

Total messages: 9 (1 generated)
M-A Ruel
5 years, 5 months ago (2015-07-15 18:22:06 UTC) #1
Vadim Sh.
lgtm https://codereview.chromium.org/1233303003/diff/1/client/utils/logging_utils.py File client/utils/logging_utils.py (right): https://codereview.chromium.org/1233303003/diff/1/client/utils/logging_utils.py#newcode145 client/utils/logging_utils.py:145: '%(process)d %(asctime)s: %(levelname)-5s %(message)s') consider also https://chromium.googlesource.com/infra/infra/+/master/infra_libs/logs/logs.py#115 for ...
5 years, 5 months ago (2015-07-15 18:46:38 UTC) #2
M-A Ruel
On 2015/07/15 18:46:38, Vadim Sh. wrote: > lgtm > > https://codereview.chromium.org/1233303003/diff/1/client/utils/logging_utils.py > File client/utils/logging_utils.py (right): ...
5 years, 5 months ago (2015-07-15 19:19:49 UTC) #3
M-A Ruel
Committed patchset #2 (id:20001) manually as b2462bd77b2eb4ef63e52aa35cfee5e561cb186d (presubmit successful).
5 years, 5 months ago (2015-07-15 19:21:47 UTC) #4
Vadim Sh.
It still inconsistent. Imagine our tools learn to parse logs (e.g. TODO on line 36 ...
5 years, 5 months ago (2015-07-15 19:22:51 UTC) #5
fdeng
https://codereview.chromium.org/1233303003/diff/20001/client/utils/tools.py File client/utils/tools.py (left): https://codereview.chromium.org/1233303003/diff/20001/client/utils/tools.py#oldcode14 client/utils/tools.py:14: import optparse auth.py refer to tools.optparse. auth.py in ToT ...
5 years, 4 months ago (2015-08-17 02:24:05 UTC) #7
Vadim Sh.
https://codereview.chromium.org/1233303003/diff/20001/client/utils/tools.py File client/utils/tools.py (left): https://codereview.chromium.org/1233303003/diff/20001/client/utils/tools.py#oldcode14 client/utils/tools.py:14: import optparse On 2015/08/17 02:24:05, fdeng wrote: > auth.py ...
5 years, 4 months ago (2015-08-17 17:44:34 UTC) #8
chromium-reviews
5 years, 4 months ago (2015-08-17 17:54:47 UTC) #9
Message was sent while issue was closed. 
Got it, I'll update, thanks vadimsh!

On Mon, Aug 17, 2015 at 10:44 AM <vadimsh@chromium.org> wrote:

>
> https://codereview.chromium.org/1233303003/diff/20001/client/utils/tools.py
> File client/utils/tools.py (left):
>
>
>
https://codereview.chromium.org/1233303003/diff/20001/client/utils/tools.py#o...
> client/utils/tools.py:14
>
<https://codereview.chromium.org/1233303003/diff/20001/client/utils/tools.py#o...>:
> import optparse
> On 2015/08/17 02:24:05, fdeng wrote:
> > auth.py refer to tools.optparse. auth.py in ToT seems broken.
>
> It was fixed 17 days ago:
>
>
https://github.com/luci/luci-py/commit/18e4bf31ad16bd3872b0e31d7a230a1e5e66d1d8
>
> https://codereview.chromium.org/1233303003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698