Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: client/tests/isolate_test.py

Issue 1233303003: Migrate and merge logging_utils from swarming_bot into client/utils. (Closed) Base URL: git@github.com:luci/luci-py.git@master
Patch Set: Changed formatter Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/tests/isolate_test.py
diff --git a/client/tests/isolate_test.py b/client/tests/isolate_test.py
index b21bef30662c7a8ce8aa9a3a04e49c6e2a0341c6..693cfafd923a3b0b6e95a35c72222b2c05987aff 100755
--- a/client/tests/isolate_test.py
+++ b/client/tests/isolate_test.py
@@ -25,6 +25,7 @@ import isolate_format
import isolated_format
import isolateserver
from utils import file_path
+from utils import logging_utils
from utils import tools
import test_utils
@@ -103,6 +104,9 @@ class IsolateBase(auto_stub.TestCase):
unicode(tempfile.mkdtemp(prefix=u'isolate_')))
# Everything should work even from another directory.
os.chdir(self.cwd)
+ self.mock(
+ logging_utils.OptionParserWithLogging, 'logger_root',
+ logging.Logger('unittest'))
def tearDown(self):
try:
@@ -1376,7 +1380,8 @@ class IsolateCommand(IsolateBase):
join('y.isolated.gen.json'),
]
self.assertEqual(
- 0, isolate.CMDbatcharchive(tools.OptionParserWithLogging(), cmd))
+ 0,
+ isolate.CMDbatcharchive(logging_utils.OptionParserWithLogging(), cmd))
expected = [
{
'base_url': 'http://localhost:1',
« no previous file with comments | « client/swarming.py ('k') | client/tests/run_isolated_test.py » ('j') | client/utils/tools.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698