Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/registry.dart

Issue 1233263003: dart2js: add isConstantsHolder to Holder class. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/program_builder/registry.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/registry.dart b/pkg/compiler/lib/src/js_emitter/program_builder/registry.dart
index 2fe3e12e8eafee84b312b5c7ed165a0cc8d869a6..5614bf99c12e512e42e230a15ac32b7fc7c66bd4 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/registry.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/registry.dart
@@ -113,10 +113,17 @@ class Registry {
// Ignore for now.
}
- Holder registerHolder(String name, {bool isStaticStateHolder: false}) {
+ Holder registerHolder(
+ String name,
+ {bool isStaticStateHolder: false, bool isConstantsHolder: false}) {
+ assert(_holdersMap[name] == null ||
+ (_holdersMap[name].isStaticStateHolder == isStaticStateHolder &&
+ _holdersMap[name].isConstantsHolder == isConstantsHolder));
+
return _holdersMap.putIfAbsent(name, () {
return new Holder(name, _holdersMap.length,
- isStaticStateHolder: isStaticStateHolder);
+ isStaticStateHolder: isStaticStateHolder,
+ isConstantsHolder: isConstantsHolder);
});
}
}
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698