Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/program_builder/registry.dart

Issue 1233263003: dart2js: add isConstantsHolder to Holder class. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter.program_builder; 5 part of dart2js.js_emitter.program_builder;
6 6
7 /// Maps [LibraryElement]s to their [Element]s. 7 /// Maps [LibraryElement]s to their [Element]s.
8 /// 8 ///
9 /// Fundamentally, this class nicely encapsulates a 9 /// Fundamentally, this class nicely encapsulates a
10 /// `Map<LibraryElement, List<Element>>`. 10 /// `Map<LibraryElement, List<Element>>`.
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 LibrariesMap targetLibrariesMap = _mapUnitToLibrariesMap(outputUnit); 106 LibrariesMap targetLibrariesMap = _mapUnitToLibrariesMap(outputUnit);
107 for (Element element in Elements.sortedByPosition(elements)) { 107 for (Element element in Elements.sortedByPosition(elements)) {
108 targetLibrariesMap.add(element.library, element); 108 targetLibrariesMap.add(element.library, element);
109 } 109 }
110 } 110 }
111 111
112 void registerConstant(OutputUnit outputUnit, ConstantValue constantValue) { 112 void registerConstant(OutputUnit outputUnit, ConstantValue constantValue) {
113 // Ignore for now. 113 // Ignore for now.
114 } 114 }
115 115
116 Holder registerHolder(String name, {bool isStaticStateHolder: false}) { 116 Holder registerHolder(
117 String name,
118 {bool isStaticStateHolder: false, bool isConstantsHolder: false}) {
119 assert(_holdersMap[name] == null ||
120 (_holdersMap[name].isStaticStateHolder == isStaticStateHolder &&
121 _holdersMap[name].isConstantsHolder == isConstantsHolder));
122
117 return _holdersMap.putIfAbsent(name, () { 123 return _holdersMap.putIfAbsent(name, () {
118 return new Holder(name, _holdersMap.length, 124 return new Holder(name, _holdersMap.length,
119 isStaticStateHolder: isStaticStateHolder); 125 isStaticStateHolder: isStaticStateHolder,
126 isConstantsHolder: isConstantsHolder);
120 }); 127 });
121 } 128 }
122 } 129 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698