Kill Func_Renderpage global function pointer, it never changes.

fpdfsdk/src/fpdfview.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../core/include/fxcodec/fx_codec.h"
 #include "../../core/include/fxcrt/fx_safe_types.h"
 #include "../../public/fpdf_ext.h"
 #include "../../public/fpdf_progressive.h"
@@ skipping 306 matching lines @@
 {
         if (!page) return 0.0;
         return ((CPDF_Page*)page)->GetPageHeight();
 }
 
 void DropContext(void* data)
 {
         delete (CRenderContext*)data;
 }
 
-void FPDF_RenderPage_Retail(CRenderContext* pContext, FPDF_PAGE page, int start_x, int start_y, int size_x, int size_y,
-                                                int rotate, int flags,FX_BOOL bNeedToRestore, IFSDK_PAUSE_Adapter * pause  );
-void (*Func_RenderPage)(CRenderContext*, FPDF_PAGE page, int start_x, int start_y, int size_x, int size_y,
-                                                int rotate, int flags,FX_BOOL bNeedToRestore, IFSDK_PAUSE_Adapter * pause  ) = FPDF_RenderPage_Retail;
-
 #if defined(_DEBUG) || defined(DEBUG)
 #define DEBUG_TRACE
 #endif
 
 #if defined(_WIN32)
 DLLEXPORT void STDCALL FPDF_RenderPage(HDC dc, FPDF_PAGE page, int start_x, int start_y, int size_x, int size_y,
                                                 int rotate, int flags)
 {
         if (page==NULL) return;
         CPDF_Page* pPage = (CPDF_Page*)page;
@@ skipping 15 matching lines @@
                 pContext->m_pDevice = new CFX_SkiaDevice;
                 ((CFX_SkiaDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)pBitmap);
 #else
                 pContext->m_pDevice = new CFX_FxgeDevice;
                 ((CFX_FxgeDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)pBitmap);
 #endif
         }
         else
             pContext->m_pDevice = new CFX_WindowsDevice(dc);
 
-        Func_RenderPage(pContext, page, start_x, start_y, size_x, size_y, rotate, flags,TRUE,NULL);
+        FPDF_RenderPage_Retail(pContext, page, start_x, start_y, size_x, size_y,
+                           rotate, flags, TRUE, NULL);
 
         if (bBackgroundAlphaNeeded)
         {
                 if (pBitmap)
                 {
                         CFX_WindowsDevice WinDC(dc);
 
                         if (WinDC.GetDeviceCaps(FXDC_DEVICE_CLASS) == FXDC_PRINTER)
                         {
                                 CFX_DIBitmap* pDst = new CFX_DIBitmap;
@@ skipping 62 matching lines @@
         pContext->m_pBitmap = new CFX_DIBitmap;
         pContext->m_pBitmap->Create(width, height, FXDIB_Rgb, (uint8_t*)pBuffer);
         pContext->m_pDevice = new CPDF_FxgeDevice;
         ((CPDF_FxgeDevice*)pContext->m_pDevice)->Attach(pContext->m_pBitmap);
 
 #ifdef DEBUG_TRACE
         CPDF_ModuleMgr::Get()->ReportError(999, "Ready for PDF rendering");
 #endif
 
         // output to bitmap device
-        Func_RenderPage(pContext, page, start_x - rect.left, start_y - rect.top, size_x, size_y, rotate, flags);
+        FPDF_RenderPage_Retail(pContext, page, start_x - rect.left,
+                           start_y - rect.top, size_x, size_y, rotate, flags);
 
 #ifdef DEBUG_TRACE
         CPDF_ModuleMgr::Get()->ReportError(999, "Finished PDF rendering");
 #endif
 
         // Now output to real device
         HDC hMemDC = CreateCompatibleDC(dc);
         if (hMemDC == NULL) {
 #if defined(DEBUG) || defined(_DEBUG)
                 char str[128];
@@ skipping 47 matching lines @@
                 ((CFX_SkiaDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap);
 #else
         pContext->m_pDevice = new CFX_FxgeDevice;
 
         if (flags & FPDF_REVERSE_BYTE_ORDER)
                 ((CFX_FxgeDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap,0,TRUE);
         else
                 ((CFX_FxgeDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap);
 #endif
 
-        Func_RenderPage(pContext, page, start_x, start_y, size_x, size_y, rotate, flags,TRUE,NULL);
+        FPDF_RenderPage_Retail(pContext, page, start_x, start_y, size_x, size_y,
+                           rotate, flags, TRUE, NULL);
 
         delete pContext;
         pPage->RemovePrivateData((void*)1);
 }
 
 DLLEXPORT void STDCALL FPDF_ClosePage(FPDF_PAGE page)
 {
         if (!page) return;
         CPDFSDK_PageView* pPageView = (CPDFSDK_PageView*)(((CPDF_Page*)page))->GetPrivateData((void*)page);
         if (pPageView && pPageView->IsLocked()) {
             pPageView->TakeOverPage();
             return;
         }
         delete (CPDF_Page*)page;
 
 }
 
 DLLEXPORT void STDCALL FPDF_CloseDocument(FPDF_DOCUMENT document)
 {
         if (!document)
                 return;
         CPDF_Document* pDoc = (CPDF_Document*)document;
         CPDF_Parser* pParser = (CPDF_Parser*)pDoc->GetParser();
         if (pParser == NULL)
         {
                 delete pDoc;
                 return;
         }
         delete pParser;
-//      delete pDoc;
 }
 
 DLLEXPORT unsigned long STDCALL FPDF_GetLastError()
 {
         return GetLastError();
 }
 
 DLLEXPORT void STDCALL FPDF_DeviceToPage(FPDF_PAGE page, int start_x, int start_y, int size_x, int size_y,
                                                 int rotate, int device_x, int device_y, double* page_x, double* page_y)
 {
@@ skipping 98 matching lines @@
         if (bitmap == NULL) return 0;
         return ((CFX_DIBitmap*)bitmap)->GetPitch();
 }
 
 DLLEXPORT void STDCALL FPDFBitmap_Destroy(FPDF_BITMAP bitmap)
 {
     delete (CFX_DIBitmap*)bitmap;
 }
 
 void FPDF_RenderPage_Retail(CRenderContext* pContext, FPDF_PAGE page, int start_x, int start_y, int size_x, int size_y,
-                                                int rotate, int flags,FX_BOOL bNeedToRestore, IFSDK_PAUSE_Adapter * pause )
+                            int rotate, int flags,FX_BOOL bNeedToRestore, IFSDK_PAUSE_Adapter * pause )
 {
         CPDF_Page* pPage = (CPDF_Page*)page;
         if (pPage == NULL) return;
 
         if (!pContext->m_pOptions)
                 pContext->m_pOptions = new CPDF_RenderOptions;
-//      CPDF_RenderOptions options;
+
         if (flags & FPDF_LCD_TEXT)
                 pContext->m_pOptions->m_Flags |= RENDER_CLEARTYPE;
         else
                 pContext->m_pOptions->m_Flags &= ~RENDER_CLEARTYPE;
         if (flags & FPDF_NO_NATIVETEXT)
                 pContext->m_pOptions->m_Flags |= RENDER_NO_NATIVETEXT;
         if (flags & FPDF_RENDER_LIMITEDIMAGECACHE)
                 pContext->m_pOptions->m_Flags |= RENDER_LIMITEDIMAGECACHE;
         if (flags & FPDF_RENDER_FORCEHALFTONE)
                 pContext->m_pOptions->m_Flags |= RENDER_FORCE_HALFTONE;
         if (flags & FPDF_RENDER_NO_SMOOTHTEXT)
                 pContext->m_pOptions->m_Flags |= RENDER_NOTEXTSMOOTH;
         if (flags & FPDF_RENDER_NO_SMOOTHIMAGE)
                 pContext->m_pOptions->m_Flags |= RENDER_NOIMAGESMOOTH;
         if (flags & FPDF_RENDER_NO_SMOOTHPATH)
                 pContext->m_pOptions->m_Flags |= RENDER_NOPATHSMOOTH;
         //Grayscale output
         if (flags & FPDF_GRAYSCALE)
         {
                 pContext->m_pOptions->m_ColorMode = RENDER_COLOR_GRAY;
                 pContext->m_pOptions->m_ForeColor = 0;
                 pContext->m_pOptions->m_BackColor = 0xffffff;
         }
         const CPDF_OCContext::UsageType usage = (flags & FPDF_PRINTING) ? CPDF_OCContext::Print : CPDF_OCContext::View;
-
         pContext->m_pOptions->m_AddFlags = flags >> 8;
-
         pContext->m_pOptions->m_pOCContext = new CPDF_OCContext(pPage->m_pDocument, usage);
 
-
         CFX_AffineMatrix matrix;
         pPage->GetDisplayMatrix(matrix, start_x, start_y, size_x, size_y, rotate);
 
         FX_RECT clip;
         clip.left = start_x;
         clip.right = start_x + size_x;
         clip.top = start_y;
         clip.bottom = start_y + size_y;
         pContext->m_pDevice->SaveState();
         pContext->m_pDevice->SetClip_Rect(&clip);
 
         pContext->m_pContext = new CPDF_RenderContext;
         pContext->m_pContext->Create(pPage);
         pContext->m_pContext->AppendObjectList(pPage, &matrix);
 
         if (flags & FPDF_ANNOT) {
                 pContext->m_pAnnots = new CPDF_AnnotList(pPage);
                 FX_BOOL bPrinting = pContext->m_pDevice->GetDeviceClass() != FXDC_DISPLAY;
                 pContext->m_pAnnots->DisplayAnnots(pPage, pContext->m_pContext, bPrinting, &matrix, TRUE, NULL);
         }
 
         pContext->m_pRenderer = new CPDF_ProgressiveRenderer;
         pContext->m_pRenderer->Start(pContext->m_pContext, pContext->m_pDevice, pContext->m_pOptions, pause);
         if (bNeedToRestore)
         {
-          pContext->m_pDevice->RestoreState();
+                pContext->m_pDevice->RestoreState();
         }
 }
 
 DLLEXPORT int STDCALL FPDF_GetPageSizeByIndex(FPDF_DOCUMENT document, int page_index, double* width, double* height)
 {
         CPDF_Document* pDoc = (CPDF_Document*)document;
         if(pDoc == NULL)
                 return FALSE;
 
         CPDF_Dictionary* pDict = pDoc->GetPage(page_index);
@@ skipping 116 matching lines @@
     if (!buffer) {
         *buflen = len;
     } else if (*buflen >= len) {
         memcpy(buffer, utf16Name.c_str(), len);
         *buflen = len;
     } else {
         *buflen = -1;
     }
     return (FPDF_DEST)pDestObj;
 }