Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptPromiseResolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/CallbackPromiseAdapter.h
diff --git a/Source/bindings/core/v8/CallbackPromiseAdapter.h b/Source/bindings/core/v8/CallbackPromiseAdapter.h
index 8f26b5c07451677a0735b2392e3c2dae058699fe..816928cda2ec94109d329d08b6c7e78f1ad8e622 100644
--- a/Source/bindings/core/v8/CallbackPromiseAdapter.h
+++ b/Source/bindings/core/v8/CallbackPromiseAdapter.h
@@ -76,7 +76,7 @@ template<typename S, typename T>
class CallbackPromiseAdapter final : public WebCallbacks<typename S::WebType*, typename T::WebType*> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -102,14 +102,14 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
template<typename T>
class CallbackPromiseAdapter<void, T> final : public WebCallbacks<void, typename T::WebType*> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -133,14 +133,14 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
template<typename S>
class CallbackPromiseAdapter<S, void> final : public WebCallbacks<typename S::WebType*, void> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -164,14 +164,14 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
template<typename T>
class CallbackPromiseAdapter<bool, T> final : public WebCallbacks<bool*, typename T::WebType*> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -197,14 +197,14 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
template<>
class CallbackPromiseAdapter<void, void> final : public WebCallbacks<void, void> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -226,14 +226,14 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
template<>
class CallbackPromiseAdapter<bool, void> final : public WebCallbacks<bool*, void> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -257,7 +257,7 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
} // namespace blink
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptPromiseResolver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698