Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptPromiseResolver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 // 69 //
70 // Note: 70 // Note:
71 // - This class does not manage its own lifetime. In this example that ownership 71 // - This class does not manage its own lifetime. In this example that ownership
72 // of the WebCallbacks instance is being passed in and it is up to the callee 72 // of the WebCallbacks instance is being passed in and it is up to the callee
73 // to free the WebCallbacks instance. 73 // to free the WebCallbacks instance.
74 // - onSuccess and onError take ownership of the given WebType instance. 74 // - onSuccess and onError take ownership of the given WebType instance.
75 template<typename S, typename T> 75 template<typename S, typename T>
76 class CallbackPromiseAdapter final : public WebCallbacks<typename S::WebType*, t ypename T::WebType*> { 76 class CallbackPromiseAdapter final : public WebCallbacks<typename S::WebType*, t ypename T::WebType*> {
77 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter); 77 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
78 public: 78 public:
79 explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver > resolver) 79 explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
80 : m_resolver(resolver) 80 : m_resolver(resolver)
81 { 81 {
82 ASSERT(m_resolver); 82 ASSERT(m_resolver);
83 } 83 }
84 ~CallbackPromiseAdapter() override { } 84 ~CallbackPromiseAdapter() override { }
85 85
86 // Takes ownership of |result|. 86 // Takes ownership of |result|.
87 void onSuccess(typename S::WebType* result) override 87 void onSuccess(typename S::WebType* result) override
88 { 88 {
89 OwnPtr<typename S::WebType> ownPtr = adoptPtr(result); 89 OwnPtr<typename S::WebType> ownPtr = adoptPtr(result);
90 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 90 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
91 return; 91 return;
92 m_resolver->resolve(S::take(m_resolver.get(), ownPtr.release())); 92 m_resolver->resolve(S::take(m_resolver.get(), ownPtr.release()));
93 } 93 }
94 94
95 // Takes ownership of |error|. 95 // Takes ownership of |error|.
96 void onError(typename T::WebType* error) override 96 void onError(typename T::WebType* error) override
97 { 97 {
98 OwnPtr<typename T::WebType> ownPtr = adoptPtr(error); 98 OwnPtr<typename T::WebType> ownPtr = adoptPtr(error);
99 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 99 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
100 return; 100 return;
101 m_resolver->reject(T::take(m_resolver.get(), ownPtr.release())); 101 m_resolver->reject(T::take(m_resolver.get(), ownPtr.release()));
102 } 102 }
103 103
104 private: 104 private:
105 RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver; 105 Persistent<ScriptPromiseResolver> m_resolver;
106 }; 106 };
107 107
108 template<typename T> 108 template<typename T>
109 class CallbackPromiseAdapter<void, T> final : public WebCallbacks<void, typename T::WebType*> { 109 class CallbackPromiseAdapter<void, T> final : public WebCallbacks<void, typename T::WebType*> {
110 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter); 110 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
111 public: 111 public:
112 explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver > resolver) 112 explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
113 : m_resolver(resolver) 113 : m_resolver(resolver)
114 { 114 {
115 ASSERT(m_resolver); 115 ASSERT(m_resolver);
116 } 116 }
117 ~CallbackPromiseAdapter() override { } 117 ~CallbackPromiseAdapter() override { }
118 118
119 void onSuccess() override 119 void onSuccess() override
120 { 120 {
121 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 121 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
122 return; 122 return;
123 m_resolver->resolve(); 123 m_resolver->resolve();
124 } 124 }
125 125
126 // Takes ownership of |error|. 126 // Takes ownership of |error|.
127 void onError(typename T::WebType* error) override 127 void onError(typename T::WebType* error) override
128 { 128 {
129 OwnPtr<typename T::WebType> ownPtr = adoptPtr(error); 129 OwnPtr<typename T::WebType> ownPtr = adoptPtr(error);
130 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 130 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
131 return; 131 return;
132 m_resolver->reject(T::take(m_resolver.get(), ownPtr.release())); 132 m_resolver->reject(T::take(m_resolver.get(), ownPtr.release()));
133 } 133 }
134 134
135 private: 135 private:
136 RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver; 136 Persistent<ScriptPromiseResolver> m_resolver;
137 }; 137 };
138 138
139 template<typename S> 139 template<typename S>
140 class CallbackPromiseAdapter<S, void> final : public WebCallbacks<typename S::We bType*, void> { 140 class CallbackPromiseAdapter<S, void> final : public WebCallbacks<typename S::We bType*, void> {
141 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter); 141 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
142 public: 142 public:
143 explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver > resolver) 143 explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
144 : m_resolver(resolver) 144 : m_resolver(resolver)
145 { 145 {
146 ASSERT(m_resolver); 146 ASSERT(m_resolver);
147 } 147 }
148 ~CallbackPromiseAdapter() override { } 148 ~CallbackPromiseAdapter() override { }
149 149
150 // Takes ownership of |result|. 150 // Takes ownership of |result|.
151 void onSuccess(typename S::WebType* result) override 151 void onSuccess(typename S::WebType* result) override
152 { 152 {
153 OwnPtr<typename S::WebType> ownPtr = adoptPtr(result); 153 OwnPtr<typename S::WebType> ownPtr = adoptPtr(result);
154 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 154 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
155 return; 155 return;
156 m_resolver->resolve(S::take(m_resolver.get(), ownPtr.release())); 156 m_resolver->resolve(S::take(m_resolver.get(), ownPtr.release()));
157 } 157 }
158 158
159 void onError() override 159 void onError() override
160 { 160 {
161 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 161 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
162 return; 162 return;
163 m_resolver->reject(); 163 m_resolver->reject();
164 } 164 }
165 165
166 private: 166 private:
167 RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver; 167 Persistent<ScriptPromiseResolver> m_resolver;
168 }; 168 };
169 169
170 template<typename T> 170 template<typename T>
171 class CallbackPromiseAdapter<bool, T> final : public WebCallbacks<bool*, typenam e T::WebType*> { 171 class CallbackPromiseAdapter<bool, T> final : public WebCallbacks<bool*, typenam e T::WebType*> {
172 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter); 172 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
173 public: 173 public:
174 explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver > resolver) 174 explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
175 : m_resolver(resolver) 175 : m_resolver(resolver)
176 { 176 {
177 ASSERT(m_resolver); 177 ASSERT(m_resolver);
178 } 178 }
179 ~CallbackPromiseAdapter() override { } 179 ~CallbackPromiseAdapter() override { }
180 180
181 // TODO(nhiroki): onSuccess should take ownership of a bool object for 181 // TODO(nhiroki): onSuccess should take ownership of a bool object for
182 // consistency. (http://crbug.com/493531) 182 // consistency. (http://crbug.com/493531)
183 void onSuccess(bool* result) override 183 void onSuccess(bool* result) override
184 { 184 {
185 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 185 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
186 return; 186 return;
187 m_resolver->resolve(*result); 187 m_resolver->resolve(*result);
188 } 188 }
189 189
190 // Takes ownership of |error|. 190 // Takes ownership of |error|.
191 void onError(typename T::WebType* error) override 191 void onError(typename T::WebType* error) override
192 { 192 {
193 OwnPtr<typename T::WebType> ownPtr = adoptPtr(error); 193 OwnPtr<typename T::WebType> ownPtr = adoptPtr(error);
194 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 194 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
195 return; 195 return;
196 m_resolver->reject(T::take(m_resolver.get(), ownPtr.release())); 196 m_resolver->reject(T::take(m_resolver.get(), ownPtr.release()));
197 } 197 }
198 198
199 private: 199 private:
200 RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver; 200 Persistent<ScriptPromiseResolver> m_resolver;
201 }; 201 };
202 202
203 template<> 203 template<>
204 class CallbackPromiseAdapter<void, void> final : public WebCallbacks<void, void> { 204 class CallbackPromiseAdapter<void, void> final : public WebCallbacks<void, void> {
205 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter); 205 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
206 public: 206 public:
207 explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver > resolver) 207 explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
208 : m_resolver(resolver) 208 : m_resolver(resolver)
209 { 209 {
210 ASSERT(m_resolver); 210 ASSERT(m_resolver);
211 } 211 }
212 ~CallbackPromiseAdapter() override { } 212 ~CallbackPromiseAdapter() override { }
213 213
214 void onSuccess() override 214 void onSuccess() override
215 { 215 {
216 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 216 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
217 return; 217 return;
218 m_resolver->resolve(); 218 m_resolver->resolve();
219 } 219 }
220 220
221 void onError() override 221 void onError() override
222 { 222 {
223 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 223 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
224 return; 224 return;
225 m_resolver->reject(); 225 m_resolver->reject();
226 } 226 }
227 227
228 private: 228 private:
229 RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver; 229 Persistent<ScriptPromiseResolver> m_resolver;
230 }; 230 };
231 231
232 template<> 232 template<>
233 class CallbackPromiseAdapter<bool, void> final : public WebCallbacks<bool*, void > { 233 class CallbackPromiseAdapter<bool, void> final : public WebCallbacks<bool*, void > {
234 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter); 234 WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
235 public: 235 public:
236 explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver > resolver) 236 explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
237 : m_resolver(resolver) 237 : m_resolver(resolver)
238 { 238 {
239 ASSERT(m_resolver); 239 ASSERT(m_resolver);
240 } 240 }
241 ~CallbackPromiseAdapter() override { } 241 ~CallbackPromiseAdapter() override { }
242 242
243 // TODO(nhiroki): onSuccess should take ownership of a bool object for 243 // TODO(nhiroki): onSuccess should take ownership of a bool object for
244 // consistency. (http://crbug.com/493531) 244 // consistency. (http://crbug.com/493531)
245 void onSuccess(bool* result) override 245 void onSuccess(bool* result) override
246 { 246 {
247 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 247 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
248 return; 248 return;
249 m_resolver->resolve(*result); 249 m_resolver->resolve(*result);
250 } 250 }
251 251
252 void onError() override 252 void onError() override
253 { 253 {
254 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped()) 254 if (!m_resolver->executionContext() || m_resolver->executionContext()->a ctiveDOMObjectsAreStopped())
255 return; 255 return;
256 m_resolver->reject(); 256 m_resolver->reject();
257 } 257 }
258 258
259 private: 259 private:
260 RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver; 260 Persistent<ScriptPromiseResolver> m_resolver;
261 }; 261 };
262 262
263 } // namespace blink 263 } // namespace blink
264 264
265 #endif 265 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptPromiseResolver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698