Source/modules/background_sync/SyncManager.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Unified Diff: Source/modules/background_sync/SyncManager.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('K') | « Source/modules/background_sync/SyncCallbacks.cpp ('k') | Source/modules/background_sync/SyncRegistration.cpp » ('j') | Source/modules/cachestorage/Cache.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/background_sync/SyncManager.cpp

diff --git a/Source/modules/background_sync/SyncManager.cpp b/Source/modules/background_sync/SyncManager.cpp

index df18fc1b2fc1c3f38dc5754dac92671796b8fe7f..99f89176ecfd37154ef3f1482d0d6cf65f40fe42 100644

--- a/Source/modules/background_sync/SyncManager.cpp

+++ b/Source/modules/background_sync/SyncManager.cpp

@@ -45,7 +45,7 @@ ScriptPromise SyncManager::registerFunction(ScriptState* scriptState, const Sync

if (!m_registration->active())

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Registration failed - no active Service Worker"));

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

WebSyncRegistration* webSyncRegistration = new WebSyncRegistration(

@@ -66,7 +66,7 @@ ScriptPromise SyncManager::getRegistration(ScriptState* scriptState, const Strin

if (!m_registration->active())

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Operation failed - no active Service Worker"));

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

backgroundSyncProvider()->getRegistration(WebSyncRegistration::PeriodicityOneShot, syncRegistrationId, m_registration->webRegistration(), new SyncRegistrationCallbacks(resolver, m_registration));

@@ -79,7 +79,7 @@ ScriptPromise SyncManager::getRegistrations(ScriptState* scriptState)

if (!m_registration->active())

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Operation failed - no active Service Worker"));

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

backgroundSyncProvider()->getRegistrations(WebSyncRegistration::PeriodicityOneShot, m_registration->webRegistration(), new SyncGetRegistrationsCallbacks(resolver, m_registration));

@@ -92,7 +92,7 @@ ScriptPromise SyncManager::permissionState(ScriptState* scriptState)

if (!m_registration->active())

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Operation failed - no active Service Worker"));

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

backgroundSyncProvider()->getPermissionStatus(WebSyncRegistration::PeriodicityOneShot, m_registration->webRegistration(), new SyncGetPermissionStatusCallbacks(resolver, m_registration));