Source/modules/background_sync/SyncCallbacks.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/background_sync/SyncCallbacks.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('K') | « Source/modules/background_sync/SyncCallbacks.h ('k') | Source/modules/background_sync/SyncManager.cpp » ('j') | Source/modules/cachestorage/Cache.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/background_sync/SyncCallbacks.cpp

diff --git a/Source/modules/background_sync/SyncCallbacks.cpp b/Source/modules/background_sync/SyncCallbacks.cpp

index ef12922311e6c1e78fefabaa42568ef11175f851..02fa918d1a0665640530629f9fe5f728713a4b3f 100644

--- a/Source/modules/background_sync/SyncCallbacks.cpp

+++ b/Source/modules/background_sync/SyncCallbacks.cpp

@@ -15,7 +15,7 @@

namespace blink {

-SyncRegistrationCallbacks::SyncRegistrationCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver, ServiceWorkerRegistration* serviceWorkerRegistration)

+SyncRegistrationCallbacks::SyncRegistrationCallbacks(ScriptPromiseResolver* resolver, ServiceWorkerRegistration* serviceWorkerRegistration)

: m_resolver(resolver)

, m_serviceWorkerRegistration(serviceWorkerRegistration)

{

@@ -57,7 +57,7 @@ void SyncRegistrationCallbacks::onError(WebSyncError* error)

m_resolver->reject(SyncError::take(m_resolver.get(), error));

}

-SyncUnregistrationCallbacks::SyncUnregistrationCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver, ServiceWorkerRegistration* serviceWorkerRegistration)

+SyncUnregistrationCallbacks::SyncUnregistrationCallbacks(ScriptPromiseResolver* resolver, ServiceWorkerRegistration* serviceWorkerRegistration)

: m_resolver(resolver)

, m_serviceWorkerRegistration(serviceWorkerRegistration)

{

@@ -88,7 +88,7 @@ void SyncUnregistrationCallbacks::onError(WebSyncError* error)

m_resolver->reject(SyncError::take(m_resolver.get(), error));

}

-SyncGetRegistrationsCallbacks::SyncGetRegistrationsCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver, ServiceWorkerRegistration* serviceWorkerRegistration)

+SyncGetRegistrationsCallbacks::SyncGetRegistrationsCallbacks(ScriptPromiseResolver* resolver, ServiceWorkerRegistration* serviceWorkerRegistration)

: m_resolver(resolver)

, m_serviceWorkerRegistration(serviceWorkerRegistration)

{

@@ -146,7 +146,7 @@ void SyncGetRegistrationsCallbacks::onError(WebSyncError* error)

m_resolver->reject(SyncError::take(m_resolver.get(), error));

}

-SyncGetPermissionStatusCallbacks::SyncGetPermissionStatusCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver, ServiceWorkerRegistration* serviceWorkerRegistration)

+SyncGetPermissionStatusCallbacks::SyncGetPermissionStatusCallbacks(ScriptPromiseResolver* resolver, ServiceWorkerRegistration* serviceWorkerRegistration)

: m_resolver(resolver)

, m_serviceWorkerRegistration(serviceWorkerRegistration)

{