Source/modules/background_sync/PeriodicSyncRegistration.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/background_sync/PeriodicSyncRegistration.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('K') | « Source/modules/background_sync/PeriodicSyncManager.cpp ('k') | Source/modules/background_sync/SyncCallbacks.h » ('j') | Source/modules/cachestorage/Cache.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/background_sync/PeriodicSyncRegistration.cpp

diff --git a/Source/modules/background_sync/PeriodicSyncRegistration.cpp b/Source/modules/background_sync/PeriodicSyncRegistration.cpp

index 5d7937c44d5af79b8b153d389326daf200cc72ce..bd9865caa70bf22a4e685cd3a7526811c178b99a 100644

--- a/Source/modules/background_sync/PeriodicSyncRegistration.cpp

+++ b/Source/modules/background_sync/PeriodicSyncRegistration.cpp

@@ -73,7 +73,7 @@ ScriptPromise PeriodicSyncRegistration::unregister(ScriptState* scriptState)

if (m_id == WebSyncRegistration::UNREGISTERED_SYNC_ID)

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Operation failed - not a valid registration object"));

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

WebSyncProvider* webSyncProvider = Platform::current()->backgroundSyncProvider();