Source/modules/background_sync/PeriodicSyncManager.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Unified Diff: Source/modules/background_sync/PeriodicSyncManager.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('K') | « Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp ('k') | Source/modules/background_sync/PeriodicSyncRegistration.cpp » ('j') | Source/modules/cachestorage/Cache.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/background_sync/PeriodicSyncManager.cpp

diff --git a/Source/modules/background_sync/PeriodicSyncManager.cpp b/Source/modules/background_sync/PeriodicSyncManager.cpp

index 6a0a97a1656b67bed88dcfec8c911e17cbd2236e..3d149c2d0284a40c62fff07113470fe83dac30dc 100644

--- a/Source/modules/background_sync/PeriodicSyncManager.cpp

+++ b/Source/modules/background_sync/PeriodicSyncManager.cpp

@@ -57,7 +57,7 @@ ScriptPromise PeriodicSyncManager::registerFunction(ScriptState* scriptState, co

if (!m_registration->active())

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Registration failed - no active Service Worker"));

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

WebSyncRegistration::NetworkState networkState;

@@ -94,7 +94,7 @@ ScriptPromise PeriodicSyncManager::getRegistration(ScriptState* scriptState, con

if (!m_registration->active())

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Operation failed - no active Service Worker"));

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

backgroundSyncProvider()->getRegistration(WebSyncRegistration::PeriodicityPeriodic, syncRegistrationTag, m_registration->webRegistration(), new SyncRegistrationCallbacks(resolver, m_registration));

@@ -107,7 +107,7 @@ ScriptPromise PeriodicSyncManager::getRegistrations(ScriptState* scriptState)

if (!m_registration->active())

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Operation failed - no active Service Worker"));

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

backgroundSyncProvider()->getRegistrations(WebSyncRegistration::PeriodicityPeriodic, m_registration->webRegistration(), new SyncGetRegistrationsCallbacks(resolver, m_registration));

@@ -120,7 +120,7 @@ ScriptPromise PeriodicSyncManager::permissionState(ScriptState* scriptState)

if (!m_registration->active())

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Operation failed - no active Service Worker"));

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

backgroundSyncProvider()->getPermissionStatus(WebSyncRegistration::PeriodicityPeriodic, m_registration->webRegistration(), new SyncGetPermissionStatusCallbacks(resolver, m_registration));