Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1233143004: syncFields() should not sync something you set up in initState(). They are separate concepts. (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

syncFields() should not sync something you set up in initState(). They are separate concepts. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c1cd923a208e161598abe7f631397ac3184938e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M sky/sdk/lib/widgets/popup_menu.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-14 17:12:13 UTC) #2
Hixie
5 years, 5 months ago (2015-07-14 17:12:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1cd923a208e161598abe7f631397ac3184938e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698