sky/sdk/lib/widgets/popup_menu.dart - Issue 1233143004: syncFields() should not sync something you set up in initState(). They are separate concepts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/widgets/popup_menu.dart

Issue 1233143004: syncFields() should not sync something you set up in initState(). They are separate concepts. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/sdk/lib/widgets/popup_menu.dart

diff --git a/sky/sdk/lib/widgets/popup_menu.dart b/sky/sdk/lib/widgets/popup_menu.dart

index 79bb6f6856f25a33efd971501c8a90578132c183..24fc5e0ed8f44e91331818df28127f8faf08e9b7 100644

--- a/sky/sdk/lib/widgets/popup_menu.dart

+++ b/sky/sdk/lib/widgets/popup_menu.dart

@@ -109,7 +109,6 @@ class PopupMenu extends AnimatedComponent {

controller = source.controller;

items = source.items;

level = source.level;

- _painter = source._painter;

super.syncFields(source);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »