Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 12330145: Fix unittest in checked mode (Closed)

Created:
7 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 10 months ago
Reviewers:
kevmoo-old, gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix unittest in checked mode (partial revert of https://codereview.chromium.org/12328090) Committed: https://code.google.com/p/dart/source/detail?r=19068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M pkg/unittest/lib/src/config.dart View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
I'm doing a quick revert of these assertions and we can investigate later. Turns out ...
7 years, 10 months ago (2013-02-26 18:45:32 UTC) #1
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r19068 (presubmit successful).
7 years, 10 months ago (2013-02-26 18:45:47 UTC) #2
gram
7 years, 10 months ago (2013-02-26 18:59:10 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698