Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1233003004: NotifyAllTileTasksCompleted for synchronous renderer compositor (Closed)

Created:
5 years, 5 months ago by ericrk
Modified:
5 years, 5 months ago
Reviewers:
boliu, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2454
Target Ref:
refs/pending/branch-heads/2454
Project:
chromium
Visibility:
Public.

Description

NotifyAllTileTasksCompleted for synchronous renderer compositor This change ensures that in cases where no work is enqueued on the tile manager when we background, the NotifyAllTileTasksCompleted signal is still delivered. Added a test to ensure that we call the appropriate callback in the synchronous renderer case. BUG=505495 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1228323004 Cr-Commit-Position: refs/heads/master@{#338589} (cherry picked from commit 0e28d110ce80a66d42268cce003e792edfef0006) NOTRY=true NOPRESUBMIT=true TBR=enne

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ericrk
Merging into M45 - have approval.
5 years, 5 months ago (2015-07-15 19:50:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233003004/1
5 years, 5 months ago (2015-07-15 22:31:10 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-15 22:31:13 UTC) #7
boliu
On 2015/07/15 22:31:13, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 5 months ago (2015-07-15 22:32:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233003004/1
5 years, 5 months ago (2015-07-15 22:34:10 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 22:37:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698