Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1228323004: NotifyAllTileTasksCompleted for synchronous renderer compositor (Closed)

Created:
5 years, 5 months ago by ericrk
Modified:
5 years, 5 months ago
Reviewers:
boliu, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NotifyAllTileTasksCompleted for synchronous renderer compositor This change ensures that in cases where no work is enqueued on the tile manager when we background, the NotifyAllTileTasksCompleted signal is still delivered. Added a test to ensure that we call the appropriate callback in the synchronous renderer case. BUG=505495 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0e28d110ce80a66d42268cce003e792edfef0006 Cr-Commit-Position: refs/heads/master@{#338589}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ericrk
5 years, 5 months ago (2015-07-11 18:02:41 UTC) #3
enne (OOO)
lgtm
5 years, 5 months ago (2015-07-13 17:51:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228323004/20001
5 years, 5 months ago (2015-07-13 20:08:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/72686) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-13 20:12:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228323004/40001
5 years, 5 months ago (2015-07-13 21:03:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 5 months ago (2015-07-13 23:32:17 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 23:33:25 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e28d110ce80a66d42268cce003e792edfef0006
Cr-Commit-Position: refs/heads/master@{#338589}

Powered by Google App Engine
This is Rietveld 408576698