Don't start prerenders for prerendered pages queued for deletion.

Don't start prerenders for prerendered pages queued for deletion.

This caused prerenders that were cancelled for some reason
to be able to launch new prerenders.

BUG=178755
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185084

[tburkard, 2013-02-27 18:58:08]

lgtm

[commit-bot: I haz the power, 2013-02-27 19:02:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/12328149/14001

[gavinp, 2013-02-27 19:29:47]

https://chromiumcodereview.appspot.com/12328149/diff/4003/chrome/browser/prer...
File chrome/browser/prerender/prerender_manager.cc (right):

https://chromiumcodereview.appspot.com/12328149/diff/4003/chrome/browser/prer...
chrome/browser/prerender/prerender_manager.cc:283: contents_child_id ==
process_id && contents_route_id == route_id) {
This expression freaks me out a bit. I had to stop a second to be sure that
contents_child_id and content_route_id are guaranteed to be set at the time the
comparison is run. It's valid, so I'm not going to say you have to change it,
but I wanted you to know about my trouble reading.

[mmenke, 2013-02-27 19:58:26]

On 2013/02/27 19:29:47, gavinp wrote:
>
https://chromiumcodereview.appspot.com/12328149/diff/4003/chrome/browser/prer...
> File chrome/browser/prerender/prerender_manager.cc (right):
> 
>
https://chromiumcodereview.appspot.com/12328149/diff/4003/chrome/browser/prer...
> chrome/browser/prerender/prerender_manager.cc:283: contents_child_id ==
> process_id && contents_route_id == route_id) {
> This expression freaks me out a bit. I had to stop a second to be sure that
> contents_child_id and content_route_id are guaranteed to be set at the time
the
> comparison is run. It's valid, so I'm not going to say you have to change it,
> but I wanted you to know about my trouble reading.

If you want to make it prettier in a followup CL, that's fine with me, and I'm
happy to review it.

I tend to find fewer if's much more readable than a bunch of densely placed if's
(The block above I have issues reading, even without rietveld's ugliness), but
think you do have a good point as well.

[commit-bot: I haz the power, 2013-02-27 21:29:16]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-02-27 21:36:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/12328149/14001

[mmenke, 2013-02-28 00:32:09]

Committed patchset #3 manually as r185084 (presubmit successful).