Use up to 8 affixes in Hunspell spellcheck suggestions

Use up to 8 affixes in Hunspell spellcheck suggestions

Chrome has been suggesting "Othello" for "hellllo" and "identically" for
"accidently" because it has been ignoring dictionary entries with more than one
affix. This CL changes Chrome behavior to take these entries into consideration
and use up to 8 affixes in suggestions.

BUG=170668
Committed: 184822

[please use gerrit instead, 2013-02-26 23:34:34]

Groby: PTAL. The test is in https://codereview.chromium.org/12334105/

[please use gerrit instead, 2013-02-26 23:37:37]

Since this CL is for Google-specific code that goes into google.patch, there's
no corresponding upstream change.

[please use gerrit instead, 2013-02-26 23:38:10]

After your LG, would you mind dcommitting this into src/third_party/hunspell,
please? I don't have the committer permissions yet.

[groby-ooo-7-16, 2013-02-27 00:45:46]

I assume you have a script to generate the Google patch? Mind including that,
for future generations? :)

https://codereview.chromium.org/12328121/diff/2001/src/hunspell/suggestmgr.cxx
File src/hunspell/suggestmgr.cxx (left):

https://codereview.chromium.org/12328121/diff/2001/src/hunspell/suggestmgr.cx...
src/hunspell/suggestmgr.cxx:66: // discarded by convert_dict, i.e. 'h->astr' is
always <= 1. Therefore, this
Do we support this in convert_dict, then?

https://codereview.chromium.org/12328121/diff/2001/src/hunspell/suggestmgr.cxx
File src/hunspell/suggestmgr.cxx (right):

https://codereview.chromium.org/12328121/diff/2001/src/hunspell/suggestmgr.cx...
src/hunspell/suggestmgr.cxx:102: memcpy(hash_item->astr, source->astr,
hash_item->entry.alen * sizeof(unsigned short));
Please make this sizeof(hash_item->astr[0]) - just in case somebody fuzzes with
the struct definition.

[please use gerrit instead, 2013-02-27 01:18:07]

Groby: PTAL. I included the steps to generate the patch in README.chromium.

https://codereview.chromium.org/12328121/diff/2001/src/hunspell/suggestmgr.cxx
File src/hunspell/suggestmgr.cxx (left):

https://codereview.chromium.org/12328121/diff/2001/src/hunspell/suggestmgr.cx...
src/hunspell/suggestmgr.cxx:66: // discarded by convert_dict, i.e. 'h->astr' is
always <= 1. Therefore, this
On 2013/02/27 00:45:46, groby wrote:
> Do we support this in convert_dict, then?

Yes, convert_dict supports multiple affixes.

https://codereview.chromium.org/12328121/diff/2001/src/hunspell/suggestmgr.cxx
File src/hunspell/suggestmgr.cxx (right):

https://codereview.chromium.org/12328121/diff/2001/src/hunspell/suggestmgr.cx...
src/hunspell/suggestmgr.cxx:102: memcpy(hash_item->astr, source->astr,
hash_item->entry.alen * sizeof(unsigned short));
On 2013/02/27 00:45:46, groby wrote:
> Please make this sizeof(hash_item->astr[0]) - just in case somebody fuzzes
with
> the struct definition.

Done.

[groby-ooo-7-16, 2013-02-27 01:22:16]

lgtm

[please use gerrit instead, 2013-02-27 01:25:23]

Groby: Please dcommit this when you get a chance. (I am not a committer yet.)

[groby-ooo-7-16, 2013-02-27 01:43:41]

Committed patchset #2 manually as r184822 (presubmit successful).