Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/io/file_impl.dart

Issue 12328104: Change new List(n) to return fixed length list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Merge to head. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/html/dart2js/html_dart2js.dart ('K') | « sdk/lib/io/directory_impl.dart ('k') | sdk/lib/io/mime_multipart_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/file_impl.dart
diff --git a/sdk/lib/io/file_impl.dart b/sdk/lib/io/file_impl.dart
index e157985ab54774912e701dd0f3bbe6f37d7ccec0..59be0f19b14ad8173724dc716bfcad65dd75022b 100644
--- a/sdk/lib/io/file_impl.dart
+++ b/sdk/lib/io/file_impl.dart
@@ -265,7 +265,7 @@ class _File extends _FileBase implements File {
Future<bool> exists() {
_ensureFileService();
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _EXISTS_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -286,7 +286,7 @@ class _File extends _FileBase implements File {
Future<File> create() {
_ensureFileService();
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _CREATE_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -306,7 +306,7 @@ class _File extends _FileBase implements File {
Future<File> delete() {
_ensureFileService();
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _DELETE_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -326,7 +326,7 @@ class _File extends _FileBase implements File {
Future<Directory> directory() {
_ensureFileService();
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _DIRECTORY_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -358,7 +358,7 @@ class _File extends _FileBase implements File {
});
return completer.future;
}
- List request = new List.fixedLength(3);
+ List request = new List(3);
request[0] = _OPEN_REQUEST;
request[1] = _name;
request[2] = mode._mode; // Direct int value for serialization.
@@ -372,7 +372,7 @@ class _File extends _FileBase implements File {
Future<int> length() {
_ensureFileService();
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _LENGTH_FROM_NAME_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -396,7 +396,7 @@ class _File extends _FileBase implements File {
Future<DateTime> lastModified() {
_ensureFileService();
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _LAST_MODIFIED_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -443,7 +443,7 @@ class _File extends _FileBase implements File {
Future<String> fullPath() {
_ensureFileService();
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _FULL_PATH_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -619,7 +619,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
if (closed) return _completeWithClosedException(completer);
_ensureFileService();
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _CLOSE_REQUEST;
request[1] = _id;
// Set the id_ to 0 (NULL) to ensure the no more async requests
@@ -650,7 +650,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<int> completer = new Completer<int>();
if (closed) return _completeWithClosedException(completer);
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _READ_BYTE_REQUEST;
request[1] = _id;
return _fileService.call(request).then((response) {
@@ -724,7 +724,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
return completer.future;
};
if (closed) return _completeWithClosedException(completer);
- List request = new List.fixedLength(3);
+ List request = new List(3);
request[0] = _READ_LIST_REQUEST;
request[1] = _id;
request[2] = bytes;
@@ -780,7 +780,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
return completer.future;
}
if (closed) return _completeWithClosedException(completer);
- List request = new List.fixedLength(3);
+ List request = new List(3);
request[0] = _WRITE_BYTE_REQUEST;
request[1] = _id;
request[2] = value;
@@ -835,7 +835,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
return completer.future;
}
- List request = new List.fixedLength(5);
+ List request = new List(5);
request[0] = _WRITE_LIST_REQUEST;
request[1] = _id;
request[2] = result.buffer;
@@ -897,7 +897,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<int> completer = new Completer<int>();
if (closed) return _completeWithClosedException(completer);
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _POSITION_REQUEST;
request[1] = _id;
return _fileService.call(request).then((response) {
@@ -924,7 +924,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
if (closed) return _completeWithClosedException(completer);
- List request = new List.fixedLength(3);
+ List request = new List(3);
request[0] = _SET_POSITION_REQUEST;
request[1] = _id;
request[2] = position;
@@ -951,7 +951,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
if (closed) return _completeWithClosedException(completer);
- List request = new List.fixedLength(3);
+ List request = new List(3);
request[0] = _TRUNCATE_REQUEST;
request[1] = _id;
request[2] = length;
@@ -978,7 +978,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<int> completer = new Completer<int>();
if (closed) return _completeWithClosedException(completer);
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _LENGTH_REQUEST;
request[1] = _id;
return _fileService.call(request).then((response) {
@@ -1005,7 +1005,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
if (closed) return _completeWithClosedException(completer);
- List request = new List.fixedLength(2);
+ List request = new List(2);
request[0] = _FLUSH_REQUEST;
request[1] = _id;
return _fileService.call(request).then((response) {
« sdk/lib/html/dart2js/html_dart2js.dart ('K') | « sdk/lib/io/directory_impl.dart ('k') | sdk/lib/io/mime_multipart_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698