Change new List(n) to return fixed length list.

sdk/lib/io/file_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 
 class _FileStream extends Stream<List<int>> {
   // Stream controller.
   StreamController<List<int>> _controller;
@@ skipping 247 matching lines @@
       throw new ArgumentError('${Error.safeToString(_name)} '
                               'is not a String');
     }
   }
 
   // Constructor from Path for file.
   _File.fromPath(Path path) : this(path.toNativePath());
 
   Future<bool> exists() {
     _ensureFileService();
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _EXISTS_REQUEST;
     request[1] = _name;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response, "Cannot open file '$_name'");
       }
       return response;
     });
   }
 
   external static _exists(String name);
 
   bool existsSync() {
     var result = _exists(_name);
     throwIfError(result, "Cannot check existence of file '$_name'");
     return result;
   }
 
   Future<File> create() {
     _ensureFileService();
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _CREATE_REQUEST;
     request[1] = _name;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response, "Cannot create file '$_name'");
       }
       return this;
     });
   }
 
   external static _create(String name);
 
   void createSync() {
     var result = _create(_name);
     throwIfError(result, "Cannot create file '$_name'");
   }
 
   Future<File> delete() {
     _ensureFileService();
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _DELETE_REQUEST;
     request[1] = _name;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response, "Cannot delete file '$_name'");
       }
       return this;
     });
   }
 
   external static _delete(String name);
 
   void deleteSync() {
     var result = _delete(_name);
     throwIfError(result, "Cannot delete file '$_name'");
   }
 
   Future<Directory> directory() {
     _ensureFileService();
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _DIRECTORY_REQUEST;
     request[1] = _name;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "Cannot retrieve directory for "
                                      "file '$_name'");
       }
       return new Directory(response);
     });
@@ skipping 11 matching lines @@
     _ensureFileService();
     Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
     if (mode != FileMode.READ &&
         mode != FileMode.WRITE &&
         mode != FileMode.APPEND) {
       Timer.run(() {
         completer.completeError(new ArgumentError());
       });
       return completer.future;
     }
-    List request = new List.fixedLength(3);
+    List request = new List(3);
     request[0] = _OPEN_REQUEST;
     request[1] = _name;
     request[2] = mode._mode;  // Direct int value for serialization.
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response, "Cannot open file '$_name'");
       }
       return new _RandomAccessFile(response, _name);
     });
   }
 
   Future<int> length() {
     _ensureFileService();
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _LENGTH_FROM_NAME_REQUEST;
     request[1] = _name;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "Cannot retrieve length of "
                                      "file '$_name'");
       }
       return response;
     });
   }
 
 
   external static _lengthFromName(String name);
 
   int lengthSync() {
     var result = _lengthFromName(_name);
     throwIfError(result, "Cannot retrieve length of file '$_name'");
     return result;
   }
 
   Future<DateTime> lastModified() {
     _ensureFileService();
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _LAST_MODIFIED_REQUEST;
     request[1] = _name;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "Cannot retrieve modification time "
                                      "for file '$_name'");
       }
       return new DateTime.fromMillisecondsSinceEpoch(response);
     });
@@ skipping 26 matching lines @@
   static RandomAccessFile _openStdioSync(int fd) {
     var id = _openStdio(fd);
     if (id == 0) {
       throw new FileIOException("Cannot open stdio file for: $fd");
     }
     return new _RandomAccessFile(id, "");
   }
 
   Future<String> fullPath() {
     _ensureFileService();
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _FULL_PATH_REQUEST;
     request[1] = _name;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "Cannot retrieve full path"
                                      " for '$_name'");
       }
       return response;
     });
@@ skipping 155 matching lines @@
 }
 
 
 class _RandomAccessFile extends _FileBase implements RandomAccessFile {
   _RandomAccessFile(int this._id, String this._name);
 
   Future<RandomAccessFile> close() {
     Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
     if (closed) return _completeWithClosedException(completer);
     _ensureFileService();
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _CLOSE_REQUEST;
     request[1] = _id;
     // Set the id_ to 0 (NULL) to ensure the no more async requests
     // can be issued for this file.
     _id = 0;
     return _fileService.call(request).then((result) {
       if (result != -1) {
         _id = result;
         return this;
       } else {
@@ skipping 10 matching lines @@
     if (id == -1) {
       throw new FileIOException("Cannot close file '$_name'");
     }
     _id = id;
   }
 
   Future<int> readByte() {
     _ensureFileService();
     Completer<int> completer = new Completer<int>();
     if (closed) return _completeWithClosedException(completer);
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _READ_BYTE_REQUEST;
     request[1] = _id;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "readByte failed for file '$_name'");
       }
       return response;
     });
   }
@@ skipping 53 matching lines @@
       // Complete asynchronously so the user has a chance to setup
       // handlers without getting exceptions when registering the
       // then handler.
       Timer.run(() {
         completer.completeError(new FileIOException(
             "Invalid arguments to readList for file '$_name'"));
       });
       return completer.future;
     };
     if (closed) return _completeWithClosedException(completer);
-    List request = new List.fixedLength(3);
+    List request = new List(3);
     request[0] = _READ_LIST_REQUEST;
     request[1] = _id;
     request[2] = bytes;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "readList failed for file '$_name'");
       }
       var read = response[1];
       var data = response[2];
@@ skipping 35 matching lines @@
       // Complete asynchronously so the user has a chance to setup
       // handlers without getting exceptions when registering the
       // then handler.
       Timer.run(() {
           completer.completeError(new FileIOException(
               "Invalid argument to writeByte for file '$_name'"));
       });
       return completer.future;
     }
     if (closed) return _completeWithClosedException(completer);
-    List request = new List.fixedLength(3);
+    List request = new List(3);
     request[0] = _WRITE_BYTE_REQUEST;
     request[1] = _id;
     request[2] = value;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "writeByte failed for file '$_name'");
       }
       return this;
     });
@@ skipping 34 matching lines @@
     try {
       result = _ensureFastAndSerializableBuffer(buffer, offset, bytes);
     } catch (e) {
       // Complete asynchronously so the user has a chance to setup
       // handlers without getting exceptions when registering the
       // then handler.
       Timer.run(() => completer.completeError(e));
       return completer.future;
     }
 
-    List request = new List.fixedLength(5);
+    List request = new List(5);
     request[0] = _WRITE_LIST_REQUEST;
     request[1] = _id;
     request[2] = result.buffer;
     request[3] = result.offset;
     request[4] = bytes;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "writeList failed for file '$_name'");
       }
@@ skipping 41 matching lines @@
           "Invalid encoding in writeStringSync: $encoding");
     }
     var data = _encodeString(string, encoding);
     return writeListSync(data, 0, data.length);
   }
 
   Future<int> position() {
     _ensureFileService();
     Completer<int> completer = new Completer<int>();
     if (closed) return _completeWithClosedException(completer);
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _POSITION_REQUEST;
     request[1] = _id;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "position failed for file '$_name'");
       }
       return response;
     });
   }
 
   external static _position(int id);
 
   int positionSync() {
     _checkNotClosed();
     var result = _position(_id);
     if (result is OSError) {
       throw new FileIOException("position failed for file '$_name'", result);
     }
     return result;
   }
 
   Future<RandomAccessFile> setPosition(int position) {
     _ensureFileService();
     Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
     if (closed) return _completeWithClosedException(completer);
-    List request = new List.fixedLength(3);
+    List request = new List(3);
     request[0] = _SET_POSITION_REQUEST;
     request[1] = _id;
     request[2] = position;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "setPosition failed for file '$_name'");
       }
       return this;
     });
   }
 
   external static _setPosition(int id, int position);
 
   void setPositionSync(int position) {
     _checkNotClosed();
     var result = _setPosition(_id, position);
     if (result is OSError) {
       throw new FileIOException("setPosition failed for file '$_name'", result);
     }
   }
 
   Future<RandomAccessFile> truncate(int length) {
     _ensureFileService();
     Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
     if (closed) return _completeWithClosedException(completer);
-    List request = new List.fixedLength(3);
+    List request = new List(3);
     request[0] = _TRUNCATE_REQUEST;
     request[1] = _id;
     request[2] = length;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "truncate failed for file '$_name'");
       }
       return this;
     });
   }
 
   external static _truncate(int id, int length);
 
   void truncateSync(int length) {
     _checkNotClosed();
     var result = _truncate(_id, length);
     if (result is OSError) {
       throw new FileIOException("truncate failed for file '$_name'", result);
     }
   }
 
   Future<int> length() {
     _ensureFileService();
     Completer<int> completer = new Completer<int>();
     if (closed) return _completeWithClosedException(completer);
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _LENGTH_REQUEST;
     request[1] = _id;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "length failed for file '$_name'");
       }
       return response;
     });
   }
 
   external static _length(int id);
 
   int lengthSync() {
     _checkNotClosed();
     var result = _length(_id);
     if (result is OSError) {
       throw new FileIOException("length failed for file '$_name'", result);
     }
     return result;
   }
 
   Future<RandomAccessFile> flush() {
     _ensureFileService();
     Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
     if (closed) return _completeWithClosedException(completer);
-    List request = new List.fixedLength(2);
+    List request = new List(2);
     request[0] = _FLUSH_REQUEST;
     request[1] = _id;
     return _fileService.call(request).then((response) {
       if (_isErrorResponse(response)) {
         throw _exceptionFromResponse(response,
                                      "flush failed for file '$_name'");
       }
       return this;
     });
   }
@@ skipping 30 matching lines @@
           new FileIOException("File closed '$_name'"));
     });
     return completer.future;
   }
 
   final String _name;
   int _id;
 
   SendPort _fileService;
 }