sdk/lib/_internal/compiler/implementation/source_file_provider.dart - Issue 12328104: Change new List(n) to return fixed length list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/source_file_provider.dart

Issue 12328104: Change new List(n) to return fixed length list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge to head. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/vm/flow_graph_builder.cc ('K') | « sdk/lib/_internal/compiler/implementation/scanner/keyword.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/optimize.dart » ('j') | sdk/lib/core/list.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/source_file_provider.dart

diff --git a/sdk/lib/_internal/compiler/implementation/source_file_provider.dart b/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

index c100694e0140304d68b541051f176a94c4697db8..fc4e9b24ac0de57f0c84d66e401006fba50e8f0a 100644

--- a/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

+++ b/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

@@ -19,7 +19,7 @@ import 'util/uri_extras.dart';

String readAll(String filename) {

var file = (new File(filename)).openSync(FileMode.READ);

var length = file.lengthSync();

- var buffer = new List<int>.fixedLength(length);

+ var buffer = new List<int>(length);

var bytes = file.readListSync(buffer, 0, length);

file.closeSync();

return new String.fromCharCodes(new Utf8Decoder(buffer).decodeRest());