runtime/vm/flow_graph_builder.cc - Issue 12328104: Change new List(n) to return fixed length list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 12328104: Change new List(n) to return fixed length list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge to head. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index 33fad69afca7109c49c68967186f8a48629d4fd8..96d82a53b6035bdbfd1311bc1260602049ba38b3 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -2005,9 +2005,9 @@ static intptr_t GetResultCidOfConstructor(ConstructorCallNode* node) {

if (node->constructor().IsFactory()) {

if ((function_class.Name() == Symbols::List().raw()) &&

(function.name() == Symbols::ListFactory().raw())) {

- return kGrowableObjectArrayCid;

- } else if ((function_class.Name() == Symbols::List().raw()) &&

- (function.name() == Symbols::ListFixedLengthFactory().raw())) {

+ if (node->arguments()->length() == 0) {

Florian Schneider 2013/02/27 12:26:55 style suggestion: return (node->arguments()->leng

+ return kGrowableObjectArrayCid;

+ }

return kArrayCid;

} else {

if (IsRecognizedConstructor(function, Symbols::ObjectArray()) &&