sdk/lib/_internal/compiler/implementation/lib/js_array.dart - Issue 12328104: Change new List(n) to return fixed length list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

Issue 12328104: Change new List(n) to return fixed length list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge to head. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

index 1c1e4920dbf0511057e3a10a6c2f10b06d87cfc8..891e202b9caba4687ec91490d2caaf9a48b1f4e1 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

@@ -254,7 +254,8 @@ class JSArray<E> implements List<E> {

String toString() => Collections.collectionToString(this);

- List<E> toList() => new List<E>.from(this);

+ List<E> toList({ bool growable: false }) =>

+ new List<E>.from(this, growable: growable);

Set<E> toSet() => new Set<E>.from(this);