sdk/lib/_internal/compiler/implementation/js/nodes.dart - Issue 12328104: Change new List(n) to return fixed length list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js/nodes.dart

Issue 12328104: Change new List(n) to return fixed length list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge to head. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/js/nodes.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js/nodes.dart b/sdk/lib/_internal/compiler/implementation/js/nodes.dart

index ccf91b945319c044dacb28f2c4517a50ac584c61..fe89432e088c8bd0599b362e0d15eb1d643a392a 100644

--- a/sdk/lib/_internal/compiler/implementation/js/nodes.dart

+++ b/sdk/lib/_internal/compiler/implementation/js/nodes.dart

@@ -1081,8 +1081,7 @@ class MiniJsParserError {

String message;

String toString() {

- var codes =

- new List.fixedLength(parser.lastPosition, fill: charCodes.$SPACE);

+ var codes = new List.filled(parser.lastPosition, charCodes.$SPACE);

var spaces = new String.fromCharCodes(codes);

return "Error in MiniJsParser:\n${parser.src}\n$spaces^\n$spaces$message\n";

}