unittest: Updates to Configuration, one deprecation

Configuration: make currentTestCase get-only
 - Should be updated only by onTestStart, onTestResult
 - Added asserts to ensure calls to the above happen in expected order with reasonable values

Configuration: removed notifyController from 
 - Does nothing, never called, never overridden

Configuration: add types to properties
 - Nice for dartdoc

deprecated throwsIllegalJSRegExpException
 - since IllegalJSRegExpException is also deprecated

Committed: https://code.google.com/p/dart/source/detail?r=19067

[kevmoo-old, 2013-02-25 21:31:16]

Addressing some issues and concerns I ran into while implementing
unittest.Configuration

In theory this includes breaking changes, but anyone broken should change their
code.

Verified affected unittest pass.

[gram, 2013-02-25 21:51:53]

Adding Siggy to check the notifyController removal. BTW if it should be removed,
then that probably applies to vm_config.dart too.

https://codereview.chromium.org/12328090/diff/1/pkg/unittest/lib/src/config.dart
File pkg/unittest/lib/src/config.dart (left):

https://codereview.chromium.org/12328090/diff/1/pkg/unittest/lib/src/config.d...
pkg/unittest/lib/src/config.dart:171: }
I think it is okay to remove this but I would want Siggy to sign off on it;
please add him as a reviewer.

[Siggi Cherem (dart-lang), 2013-02-25 23:20:49]

lgtm

https://codereview.chromium.org/12328090/diff/1/pkg/unittest/lib/src/config.dart
File pkg/unittest/lib/src/config.dart (left):

https://codereview.chromium.org/12328090/diff/1/pkg/unittest/lib/src/config.d...
pkg/unittest/lib/src/config.dart:171: }
On 2013/02/25 21:51:53, gram wrote:
> I think it is okay to remove this but I would want Siggy to sign off on it;
> please add him as a reviewer.

yeah - it's fine to remove this, but please remove it also from vm_config. 

I added this a few months ago with the hope that we could get rid of the
'unittest-suite-wait-for-done' messages when running in the vm_config, but we
decided to drop that effort temporarily until we figure out a better way to fix
the issues related to configuration specific code.

In particular, removing that print could break the way dart2js runs tests (which
could happen if people accidentally override a method like this), so the dart2js
team prefers that we don't make it over-writable for now.

[kevmoo-old, 2013-02-26 00:22:28]

Fixed vm_config.

I don't have commit access, so if this looks good, please do the honors.

[Siggi Cherem (dart-lang), 2013-02-26 18:35:10]

Committed patchset #2 manually as r19067 (presubmit successful).

[Siggi Cherem (dart-lang), 2013-02-26 18:35:30]

(FYI - I did one small edit, added an import to 'meta' where @deprecated is
defined)